Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger rules/filters for "entity update notifications" as an admin #2775

Open
4 tasks done
Ayush8923 opened this issue Jan 6, 2025 · 2 comments · Fixed by #2767
Open
4 tasks done

Trigger rules/filters for "entity update notifications" as an admin #2775

Ayush8923 opened this issue Jan 6, 2025 · 2 comments · Fixed by #2767
Milestone

Comments

@Ayush8923
Copy link
Contributor

Ayush8923 commented Jan 6, 2025

  • Fetch the Entity field corresponding to the selected entity.
  • Create a conditional filter that allows users to compare fields.
  • Create the own component which is handle the notification condition form.
  • Save the condition corresponding to the notification rule.
@Ayush8923
Copy link
Contributor Author

Ayush8923 commented Jan 6, 2025

@sleidig @george-neha I’ve implemented the initial UI for the notification condition rules. I have added the screenshot below for reference. The notification conditions are displayed when the user clicks on the accordion icon, expanding the corresponding row. This allows users to add notification conditions for each entity individually. Please share your suggestions/thoughts.

Screenshot 2025-01-06 at 12 01 58 PM

@sleidig
Copy link
Member

sleidig commented Jan 6, 2025

Works fairly well, I think 👍. The criteria should automatically be expanded for a newly created rule.

The button "Add new notification condition" looks a bit too similar to "add new notification rule" in my opinion. Maybe we should make that "align: start" and just a simple outlined button?

@sleidig sleidig self-assigned this Jan 10, 2025
@Ayush8923 Ayush8923 moved this from In Progress to Technical Review in All Tasks & Issues Jan 13, 2025
@tomwwinter tomwwinter moved this from Technical Review to Done in All Tasks & Issues Jan 19, 2025
@tomwwinter tomwwinter moved this from Done to Functional Review in All Tasks & Issues Jan 19, 2025
@tomwwinter tomwwinter moved this from Functional Review to Done in All Tasks & Issues Jan 20, 2025
@sleidig sleidig changed the title Configure rules/filters for "entity update notifications" as an admin Trigger rules/filters for "entity update notifications" as an admin Jan 20, 2025
@sleidig sleidig assigned tomwwinter and unassigned sleidig and Ayush8923 Jan 20, 2025
@sleidig sleidig moved this from Done to In Progress in All Tasks & Issues Jan 20, 2025
@sleidig sleidig moved this from In Progress to Functional Review in All Tasks & Issues Jan 30, 2025
@sleidig sleidig moved this from Functional Review to In Progress in All Tasks & Issues Feb 10, 2025
@sleidig sleidig moved this from In Progress to Planned (current "sprint") in All Tasks & Issues Feb 17, 2025
@tomwwinter tomwwinter moved this from Planned (current "sprint") to In Progress in All Tasks & Issues Feb 18, 2025
@tomwwinter tomwwinter moved this from In Progress to Planned (current "sprint") in All Tasks & Issues Feb 18, 2025
@tomwwinter tomwwinter moved this from Planned (current "sprint") to In Progress in All Tasks & Issues Feb 19, 2025
@sleidig sleidig moved this from In Progress to Planned (current "sprint") in All Tasks & Issues Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Planned (current "sprint")
Development

Successfully merging a pull request may close this issue.

3 participants