Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch2 version outdated #35

Closed
arintanen opened this issue May 22, 2023 · 1 comment
Closed

Catch2 version outdated #35

arintanen opened this issue May 22, 2023 · 1 comment

Comments

@arintanen
Copy link
Member

Catch2 v2.9.2 and hence the unit tests don't compile with newer glibc versions, where MINSIGSTKSZ is not longer defined as a constant (more info at catchorg/Catch2#2178). It is fixed since version v2.13.5 and the catch.hpp headerfile should be updated with a newer version. Defining it as a constant worked as a temporary fix for me.

Also some user modifications is required in ODE_DLB/Make/options.mkl file if MKL is installed from Ubuntu's repositories. By default, headers and libraries are installed into separate folders /usr/include/mkl and /usr/lib/x86_64-linux-gnu/mkl/, but the include and linking paths are defined as -L${MKLROOT}/lib/intel64/ and -I${MKLROOT}/include/ in the project.

moreff added a commit that referenced this issue May 29, 2023
This kind of duplication of include paths is not an optimal solution, but it works.
Addresses part of issue #35
moreff added a commit that referenced this issue May 29, 2023
This kind of duplication of include paths is not an optimal solution, but it works.
Addresses part of issue #35
moreff added a commit that referenced this issue May 29, 2023
This kind of duplication of include paths is not an optimal solution, but it works.
Addresses part of issue #35
@moreff moreff closed this as completed in 70bf5ff May 29, 2023
moreff added a commit that referenced this issue May 29, 2023
This kind of duplication of include paths is not an optimal solution, but it works.
Addresses part of issue #35
@moreff
Copy link
Member

moreff commented May 29, 2023

Thank you for this comment! This issue was also discussed at #21
I resolved it now in all v1.1 branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants