From 5ed0ccf276314ea0d2535d05b0dfd890ac4d1239 Mon Sep 17 00:00:00 2001 From: antonTan96 Date: Mon, 13 Nov 2023 22:58:09 +0800 Subject: [PATCH] Fix checkstyle issues --- .../java/seedu/address/logic/commands/AddProjectCommand.java | 2 +- .../seedu/address/logic/commands/AssignProjectCommand.java | 4 ++-- .../seedu/address/logic/commands/DeleteProjectCommand.java | 2 +- .../seedu/address/logic/commands/AddProjectCommandTest.java | 2 +- .../address/logic/commands/DeleteProjectCommandTest.java | 2 -- .../address/logic/parser/AssignProjectCommandParserTest.java | 3 +-- 6 files changed, 6 insertions(+), 9 deletions(-) diff --git a/src/main/java/seedu/address/logic/commands/AddProjectCommand.java b/src/main/java/seedu/address/logic/commands/AddProjectCommand.java index 767dfeb3a44..2abd689484f 100644 --- a/src/main/java/seedu/address/logic/commands/AddProjectCommand.java +++ b/src/main/java/seedu/address/logic/commands/AddProjectCommand.java @@ -63,7 +63,7 @@ public CommandResult execute(Model model) throws CommandException { } private void employeeIsInList(int target, int size) throws CommandException { - if(target >= size) { + if (target >= size) { logger.warning("Invalid employee index: " + (target + 1)); throw new CommandException(Messages.MESSAGE_INVALID_EMPLOYEE_DISPLAYED_INDEX); } diff --git a/src/main/java/seedu/address/logic/commands/AssignProjectCommand.java b/src/main/java/seedu/address/logic/commands/AssignProjectCommand.java index a0c8830e43f..3640a22ee86 100644 --- a/src/main/java/seedu/address/logic/commands/AssignProjectCommand.java +++ b/src/main/java/seedu/address/logic/commands/AssignProjectCommand.java @@ -72,14 +72,14 @@ public CommandResult execute(Model model) throws CommandException { } private void employeeIsInList(int target, int size) throws CommandException { - if(target >= size) { + if (target >= size) { logger.warning("Invalid employee index: " + (target + 1)); throw new CommandException(Messages.MESSAGE_INVALID_EMPLOYEE_DISPLAYED_INDEX); } } private void projectIsInList(int target, int size) throws CommandException { - if(target >= size) { + if (target >= size) { logger.warning("Invalid project index: " + (target + 1)); throw new CommandException(Messages.MESSAGE_INVALID_PROJECT_DISPLAYED_INDEX); } diff --git a/src/main/java/seedu/address/logic/commands/DeleteProjectCommand.java b/src/main/java/seedu/address/logic/commands/DeleteProjectCommand.java index eec40983f09..be4454d8a41 100644 --- a/src/main/java/seedu/address/logic/commands/DeleteProjectCommand.java +++ b/src/main/java/seedu/address/logic/commands/DeleteProjectCommand.java @@ -23,8 +23,8 @@ public class DeleteProjectCommand extends Command { + ": Deletes the project identified by the index number used in the displayed project list.\n" + "Parameters: INDEX (must be a positive integer)\n" + "Example: " + COMMAND_WORD + " 1"; - private static final Logger logger = LogsCenter.getLogger(DeadlineProjectCommand.class); public static final String MESSAGE_DELETE_PROJECT_SUCCESS = "Deleted Project: %1$s"; + private static final Logger logger = LogsCenter.getLogger(DeadlineProjectCommand.class); private final Index targetIndex; public DeleteProjectCommand(Index targetIndex) { diff --git a/src/test/java/seedu/address/logic/commands/AddProjectCommandTest.java b/src/test/java/seedu/address/logic/commands/AddProjectCommandTest.java index 93f299426d0..65ddb9b9626 100644 --- a/src/test/java/seedu/address/logic/commands/AddProjectCommandTest.java +++ b/src/test/java/seedu/address/logic/commands/AddProjectCommandTest.java @@ -64,7 +64,7 @@ public void execute_duplicateProject_throwsCommandException() { // Invalid input: Employee index does not exist in TaskHub @Test - public void execute_addEmployeeToProject_employeeDoesNotExist_throwsCommandException() { + public void execute_addNonExistentEmployee_throwsCommandException() { Project project = new ProjectBuilder().build(); ArrayList invalidIndex = new ArrayList<>(); ModelStub modelStub = new ModelStubWithProject(project); diff --git a/src/test/java/seedu/address/logic/commands/DeleteProjectCommandTest.java b/src/test/java/seedu/address/logic/commands/DeleteProjectCommandTest.java index 0e948d80b66..dd6f766609a 100644 --- a/src/test/java/seedu/address/logic/commands/DeleteProjectCommandTest.java +++ b/src/test/java/seedu/address/logic/commands/DeleteProjectCommandTest.java @@ -4,7 +4,6 @@ import static org.junit.jupiter.api.Assertions.assertTrue; import static seedu.address.logic.commands.CommandTestUtil.assertCommandFailure; import static seedu.address.logic.commands.CommandTestUtil.assertCommandSuccess; -import static seedu.address.testutil.Assert.assertThrows; import static seedu.address.testutil.TypicalEmployees.getTypicalTaskHub; import static seedu.address.testutil.TypicalIndexes.INDEX_FIRST_EMPLOYEE; import static seedu.address.testutil.TypicalIndexes.INDEX_SECOND_EMPLOYEE; @@ -18,7 +17,6 @@ import seedu.address.model.UserPrefs; import seedu.address.model.project.Project; -import java.util.ArrayList; public class DeleteProjectCommandTest { diff --git a/src/test/java/seedu/address/logic/parser/AssignProjectCommandParserTest.java b/src/test/java/seedu/address/logic/parser/AssignProjectCommandParserTest.java index dcc60fd03f1..e2bbad3726e 100644 --- a/src/test/java/seedu/address/logic/parser/AssignProjectCommandParserTest.java +++ b/src/test/java/seedu/address/logic/parser/AssignProjectCommandParserTest.java @@ -16,7 +16,6 @@ import org.junit.jupiter.api.Test; import seedu.address.commons.core.index.Index; -import seedu.address.logic.Messages; import seedu.address.logic.commands.AssignProjectCommand; public class AssignProjectCommandParserTest { @@ -77,7 +76,7 @@ public void parse_missingCompulsoryField_failure() { assertParseFailure(parser, AssignProjectCommand.COMMAND_WORD, expectedMessage); // no employee index - assertParseFailure(parser, " " + PREFIX_PROJECT + INDEX_FIRST_EMPLOYEE.getOneBased(), expectedMessage); + assertParseFailure(parser, " " + PREFIX_PROJECT + INDEX_FIRST_EMPLOYEE.getOneBased(), expectedMessage); // no project index assertParseFailure(parser, " " + PREFIX_EMPLOYEE + INDEX_FIRST_EMPLOYEE.getOneBased(), expectedMessage);