Sorry že vám kecám už do WIPU :-D

Reviewed 4 of 7 files at r1.
Review status: 4 of 7 files reviewed at latest revision, 7 unresolved discussions, some commit checks failed.

src/Entity/Event.php, line 19 at r2 (raw file):

	 * @ORM\Column(type="Uuid", unique=true)
	 * @ORM\GeneratedValue(strategy="CUSTOM")
	 * @ORM\CustomIdGenerator(class="Ramsey\Uuid\Doctrine\UuidGenerator")

Takhle to sice najdete v DOCu, ale takhle dostane entita ID až při persistu, takžé člověk přijde o jednu z výhod UUID, že existuje nezávisle na DB enginu. Navíc takhle je ID vlastně nullable.

Ideálně používejte příštup co mám v example, tzn. ID generujete v constructoru. (Když se entita načíťá z DB tak se konstruktor nepoužívá o to se nemusíte bát._

src/Entity/Event.php, line 21 at r2 (raw file):

	 * @ORM\CustomIdGenerator(class="Ramsey\Uuid\Doctrine\UuidGenerator")
	 */
	protected $id;

Tedy je otázka jestli psáť propery protected nebo private.

Když pak dědíš tedy entitu rozšířuješ, tak bys nutně rodiče měnit nemusle, měl bys u value objectu jen rozšiřovat. Tzn. není nutné aby bylo protected.

src/Entity/Event.php, line 51 at r2 (raw file):

	public function __construct() {
	}

getter na ID missing.

src/Entity/EventType.php, line 16 at r2 (raw file):

	 * @ORM\Id
	 * @ORM\Column(type="integer")
	 * @ORM\GeneratedValue

Tohle už vůbec nebude fungovat.

src/Entity/EventType.php, line 38 at r2 (raw file):

		$this->name = $name;
	}

getter na ID

src/Entity/SubEvent.php, line 19 at r2 (raw file):

	 * @ORM\Column(type="Uuid", unique=true)
	 * @ORM\GeneratedValue(strategy="CUSTOM")
	 * @ORM\CustomIdGenerator(class="Ramsey\Uuid\Doctrine\UuidGenerator")

Viz výše.

src/Entity/SubEvent.php, line 34 at r2 (raw file):

	 * @var string
	 *
	 * @ORM\Column(type="string")

type="text"

Comments from Reviewable

Review status: 4 of 7 files reviewed at latest revision, 7 unresolved discussions, some commit checks failed.

src/Entity/EventType.php, line 16 at r2 (raw file):

Copypasta z dokumentace nebude fungovat? :-O Huh :)

src/Entity/EventType.php, line 38 at r2 (raw file):

getter na ID? V tvem examplu nebyl, tak jsem myslel, ze to je umyslne ;)

Comments from Reviewable

Review status: 4 of 7 files reviewed at latest revision, 7 unresolved discussions.

src/Entity/Event.php, line 19 at r2 (raw file):

Done.

src/Entity/Event.php, line 51 at r2 (raw file):

Done.

src/Entity/EventType.php, line 16 at r2 (raw file):

Done.

src/Entity/EventType.php, line 38 at r2 (raw file):

Done.

src/Entity/SubEvent.php, line 19 at r2 (raw file):

Done.

src/Entity/SubEvent.php, line 34 at r2 (raw file):

Done.

Comments from Reviewable

Review status: 4 of 7 files reviewed at latest revision, 7 unresolved discussions.

src/Entity/Event.php, line 21 at r2 (raw file):

Done.

Comments from Reviewable