Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCPStream issues #54

Open
adbridge opened this issue Dec 31, 2015 · 2 comments
Open

TCPStream issues #54

adbridge opened this issue Dec 31, 2015 · 2 comments
Labels

Comments

@adbridge
Copy link
Contributor

  1. When instantiating the class using the constructor:
    TCPStream(const socket_stack_t stack);

    there is no guarantee of a valid api being set. Thus if the connect method is then used, _socket.api
    could be NULL. Should check this within the connect method.
    If this is added then the method header should be updated accordingly.

  2. Similarly for the setNagle() method. _socket.api could be invoked with a NULL value.
    Also setNagle calls set_option() which returns an error type which is then ignored. Shouldn't this
    error type be forwarded up to the caller of the method?

@ciarmcom
Copy link
Member

ARM Internal Ref: IOTSFW-1616

adbridge added a commit to adbridge/sockets that referenced this issue Dec 31, 2015
@adbridge
Copy link
Contributor Author

@bremoran bump.
Point 2 above still needs commenting / a decision made on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants