Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate test case descriptions #262

Closed
gilles-peskine-arm opened this issue Sep 16, 2019 · 2 comments · Fixed by #270
Closed

Duplicate test case descriptions #262

gilles-peskine-arm opened this issue Sep 16, 2019 · 2 comments · Fixed by #270

Comments

@gilles-peskine-arm
Copy link
Collaborator

Description

We have 1420 duplicated test case descriptions, i.e. two test cases in the same test suite that have the exact same description.

This doesn't break any tooling yet, but it makes the outcome file introduced by Mbed-TLS/mbedtls#2843 imprecise. It also makes it hard to figure out which test case is failing when looking at logs.

Mbed-TLS/mbedtls#2843 adds a script tests/scripts/check-test-cases.py that checks this issue and fixes the problem in the tests that are present in mbedtls/development.

Issue request type

[ ] Question
[ ] Enhancement
[x] Bug
@ciarmcom
Copy link
Member

Internal Jira reference: https://jira.arm.com/browse/IOTCRYPT-916

@gilles-peskine-arm
Copy link
Collaborator Author

The scope of this issue is solely to make test case descriptions unique. Making them correct and helpful is out of scope. Reviewing the correctness of the non-unique test descriptions is in scope for #271.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants