From ec8cedd551d08f6508a4f69cde7b0d876e3a1004 Mon Sep 17 00:00:00 2001
From: Felix Ruf <felix.ruf@aoe.com>
Date: Wed, 17 Jan 2024 16:18:25 +0100
Subject: [PATCH 1/3] added indicators to events in the dashboard

---
 .../src/components/dashboard/Day.vue          |  8 +--
 .../src/components/dashboard/EventData.vue    | 50 +++++++++++++------
 .../src/components/misc/BannerSpacer.vue      | 21 ++++++++
 .../src/components/misc/EventIcon.vue         | 10 ++--
 src/Resources/src/locales/de.json             |  3 +-
 src/Resources/src/locales/en.json             |  3 +-
 6 files changed, 70 insertions(+), 25 deletions(-)
 create mode 100644 src/Resources/src/components/misc/BannerSpacer.vue

diff --git a/src/Resources/src/components/dashboard/Day.vue b/src/Resources/src/components/dashboard/Day.vue
index edfc2d7be..5b71cb35c 100644
--- a/src/Resources/src/components/dashboard/Day.vue
+++ b/src/Resources/src/components/dashboard/Day.vue
@@ -2,7 +2,7 @@
   <div class="day-shadow mx-auto grid h-auto max-w-[414px] grid-cols-[auto_minmax(0,1fr)] grid-rows-[minmax(0,1fr)_auto] rounded bg-white sm:max-w-none">
     <div
       class="relative col-span-1 col-start-1 row-span-2 row-start-1 grid w-[24px] justify-center gap-2 rounded-l-[5px] py-[2px]"
-      :class="[day.isLocked || !day.isEnabled || emptyDay ? 'bg-[#80909F]' : 'bg-primary-2', !day.isLocked && !emptyDay && !guestData ? 'grid-rows-[minmax(0,1fr)_24px]' : '']"
+      :class="[(day.isLocked || !day.isEnabled || emptyDay) && !isEventDay ? 'bg-[#80909F]' : 'bg-primary-2', !day.isLocked && !emptyDay && !guestData ? 'grid-rows-[minmax(0,1fr)_24px]' : '']"
     >
       <span
         class="row-start-1 rotate-180 place-self-center text-center text-[11px] font-bold uppercase leading-4 tracking-[3px] text-white [writing-mode:vertical-lr]"
@@ -36,7 +36,8 @@
       <div
         v-for="(meal, mealID) in day.meals"
         :key="mealID"
-        class="mx-[15px] border-b-[0.7px] py-[13px] last:border-b-0"
+        class="mx-[15px] border-b-[0.7px] last:border-b-0"
+        :class="day.event !== null ? 'pt-[13px] pb-[13px] last:pb-0 last:pt-[21px]' : 'py-[13px]'"
       >
         <VariationsData
           v-if="meal.variations"
@@ -64,7 +65,7 @@
     </div>
     <EventData
       v-if="day.event !== null"
-      class="col-start-2 row-start-2 border-t-2"
+      class="col-start-2 row-start-2"
       :day="day"
     />
   </div>
@@ -94,6 +95,7 @@ const props = defineProps<{
 const day = props.guestData ? props.guestData : dashboardStore.getDay(props.weekID, props.dayID);
 const weekday = computed(() => translateWeekday(day.date, locale));
 const emptyDay = Object.keys(day.meals).length === 0;
+const isEventDay = day.event !== null;
 </script>
 
 <style>
diff --git a/src/Resources/src/components/dashboard/EventData.vue b/src/Resources/src/components/dashboard/EventData.vue
index e265dbc15..cd90f3ef3 100644
--- a/src/Resources/src/components/dashboard/EventData.vue
+++ b/src/Resources/src/components/dashboard/EventData.vue
@@ -1,28 +1,43 @@
 <template>
   <div
-    class="flex w-full flex-row items-center px-[15px] py-[13px]"
+    class="grid w-full grid-cols-1 grid-rows-[minmax(0,2fr)_auto_minmax(0,1fr)]"
   >
-    <div class="grid w-full grid-cols-[24px_minmax(0,1fr)] gap-1">
+    <BannerSpacer>
       <EventIcon
-        class="w-[24px] self-center"
+        class="w-[20px] self-center"
+        :size="20"
       />
+      <span
+        class="text-[14px] font-bold leading-[20px] tracking-[0.5px] text-primary-1"
+      >
+        {{ t('event.event') }}
+      </span>
+      <EventIcon
+        class="w-[20px] self-center"
+        :size="20"
+      />
+    </BannerSpacer>
+    <div
+      class="flex w-full flex-row items-center px-[15px]"
+    >
       <span class="mr-[5px] inline-block grow self-center break-words text-[12px] font-bold leading-[20px] tracking-[0.5px] text-primary-1 min-[380px]:text-note">
         {{ getEventById(day.event.eventId)?.title }}
       </span>
+      <ParticipationCounter
+        class="justify-self-end"
+        :limit="0"
+        :mealCSS="new Date(day.date.date) > new Date() ? 'bg-primary-4' : 'bg-[#80909F]'"
+      >
+        {{ day.event?.participations }}
+      </ParticipationCounter>
+      <CheckBox
+        class="justify-self-end"
+        :isActive="new Date(day.date.date) > new Date()"
+        :isChecked="day.event?.isParticipating ?? false"
+        @click="day.event?.isParticipating === false ? joinEvent(day.date.date) : leaveEvent(day.date.date)"
+      />
     </div>
-    <ParticipationCounter
-      class="justify-self-end"
-      :limit="0"
-      :mealCSS="new Date(day.date.date) > new Date() ? 'bg-primary-4' : 'bg-[#80909F]'"
-    >
-      {{ day.event?.participations }}
-    </ParticipationCounter>
-    <CheckBox
-      class="justify-self-end"
-      :isActive="new Date(day.date.date) > new Date()"
-      :isChecked="day.event?.isParticipating ?? false"
-      @click="day.event?.isParticipating === false ? joinEvent(day.date.date) : leaveEvent(day.date.date)"
-    />
+    <div />
   </div>
 </template>
 
@@ -32,10 +47,13 @@ import { useEvents } from '@/stores/eventsStore';
 import ParticipationCounter from '../menuCard/ParticipationCounter.vue';
 import CheckBox from '../misc/CheckBox.vue';
 import EventIcon from '../misc/EventIcon.vue';
+import BannerSpacer from '../misc/BannerSpacer.vue';
+import { useI18n } from 'vue-i18n';
 
 defineProps<{
   day: Day
 }>();
 
+const { t } = useI18n();
 const { getEventById, joinEvent, leaveEvent } = useEvents();
 </script>
\ No newline at end of file
diff --git a/src/Resources/src/components/misc/BannerSpacer.vue b/src/Resources/src/components/misc/BannerSpacer.vue
new file mode 100644
index 000000000..aa8dd9ec6
--- /dev/null
+++ b/src/Resources/src/components/misc/BannerSpacer.vue
@@ -0,0 +1,21 @@
+<template>
+  <div
+    class="justify-content grid w-full grid-cols-[minmax(0,1fr)_minmax(0,3fr)_minmax(0,1fr)] grid-rows-1 items-center py-2"
+  >
+    <div
+      class="col-span-1 col-start-1 h-[2px] bg-[#e5e7eb]"
+    />
+    <span
+      class="col-span-1 col-start-2 flex h-full flex-row items-center justify-around gap-2 rounded-full border-[2px] border-solid px-4 py-1"
+    >
+      <slot />
+    </span>
+    <div
+      class="col-span-1 col-start-3 h-[2px] bg-[#e5e7eb]"
+    />
+  </div>
+</template>
+
+<script setup lang="ts">
+
+</script>
\ No newline at end of file
diff --git a/src/Resources/src/components/misc/EventIcon.vue b/src/Resources/src/components/misc/EventIcon.vue
index b7b91dd10..140d0929e 100644
--- a/src/Resources/src/components/misc/EventIcon.vue
+++ b/src/Resources/src/components/misc/EventIcon.vue
@@ -1,9 +1,9 @@
 <template>
   <svg
     xmlns="http://www.w3.org/2000/svg"
-    height="24"
+    :height="size"
     viewBox="0 -960 960 960"
-    width="24"
+    :width="size"
   >
     <path
       d="m212-212 282-100-182-182-100 282Zm709-467q-9 9-21 9t-21-9l-3-3q-14-14-35-14t-35 14L603-479q-9 9-21 9t-21-9q-9-9-9-21t9-21l203-203q32-32 77-32t77 32l3 3q9 9 9 21t-9 21ZM399-799q9-9 21-9t21 9l5 5q32 32 32 76t-32 76l-3 3q-9 9-21 9t-21-9q-9-9-9-21t9-21l3-3q14-14 14-34t-14-34l-5-5q-9-9-9-21t9-21Zm162-80q9-9 21-9t21 9l43 43q32 32 32 77t-32 77L523-559q-9 9-21 9t-21-9q-9-9-9-21t9-21l123-123q14-14 14-35t-14-35l-43-43q-9-9-9-21t9-21Zm320 480q-9 9-21 9t-21-9l-43-43q-14-14-35-14t-35 14l-43 43q-9 9-21 9t-21-9q-9-9-9-21t9-21l43-43q32-32 77-32t77 32l43 43q9 9 9 21t-9 21ZM212-212Zm-104 52 151-420q5-13 15.5-20t22.5-7q8 0 15 3t13 9l270 270q6 6 9 13t3 15q0 12-7 22.5T580-259L160-108q-12 5-23 1.5T118-118q-8-8-11.5-19t1.5-23Z"
@@ -14,8 +14,10 @@
 
 <script setup lang="ts">
 withDefaults(defineProps<{
-  fillColour?: string
+  fillColour?: string,
+  size?: number
 }>(), {
-  fillColour: 'fill-primary'
+  fillColour: 'fill-primary',
+  size: 24
 })
 </script>
\ No newline at end of file
diff --git a/src/Resources/src/locales/de.json b/src/Resources/src/locales/de.json
index 049264323..af74d74ed 100644
--- a/src/Resources/src/locales/de.json
+++ b/src/Resources/src/locales/de.json
@@ -132,7 +132,8 @@
       "submit": "Erstellen",
       "title": "Titel",
       "isPublic": "Öffentliches Event?"
-    }
+    },
+    "event": "Event"
   },
   "flashMessage": {
     "error": {
diff --git a/src/Resources/src/locales/en.json b/src/Resources/src/locales/en.json
index 92e5c3de4..8677c025a 100644
--- a/src/Resources/src/locales/en.json
+++ b/src/Resources/src/locales/en.json
@@ -132,7 +132,8 @@
       "submit": "Create",
       "title": "Title",
       "isPublic": "Public event?"
-    }
+    },
+    "event": "Event"
   },
   "flashMessage": {
     "error": {

From 5985e38049e5b686222aca8c266b8e81e3b18eaf Mon Sep 17 00:00:00 2001
From: Felix Ruf <felix.ruf@aoe.com>
Date: Thu, 18 Jan 2024 08:54:09 +0100
Subject: [PATCH 2/3] fixed color on event days

---
 src/Resources/src/components/dashboard/Day.vue | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/src/Resources/src/components/dashboard/Day.vue b/src/Resources/src/components/dashboard/Day.vue
index 5b71cb35c..26dc1315d 100644
--- a/src/Resources/src/components/dashboard/Day.vue
+++ b/src/Resources/src/components/dashboard/Day.vue
@@ -1,8 +1,9 @@
 <template>
-  <div class="day-shadow mx-auto grid h-auto max-w-[414px] grid-cols-[auto_minmax(0,1fr)] grid-rows-[minmax(0,1fr)_auto] rounded bg-white sm:max-w-none">
+  <div class="day-shadow mx-auto grid h-auto min-h-[153px] max-w-[414px] grid-cols-[auto_minmax(0,1fr)] grid-rows-[minmax(0,1fr)_auto] rounded bg-white sm:max-w-none">
     <div
       class="relative col-span-1 col-start-1 row-span-2 row-start-1 grid w-[24px] justify-center gap-2 rounded-l-[5px] py-[2px]"
-      :class="[(day.isLocked || !day.isEnabled || emptyDay) && !isEventDay ? 'bg-[#80909F]' : 'bg-primary-2', !day.isLocked && !emptyDay && !guestData ? 'grid-rows-[minmax(0,1fr)_24px]' : '']"
+      :class="[day.isLocked || !day.isEnabled || (emptyDay && !isEventDay) ? 'bg-[#80909F]' : 'bg-primary-2',
+               !day.isLocked && !emptyDay && !guestData ? 'grid-rows-[minmax(0,1fr)_24px]' : '']"
     >
       <span
         class="row-start-1 rotate-180 place-self-center text-center text-[11px] font-bold uppercase leading-4 tracking-[3px] text-white [writing-mode:vertical-lr]"
@@ -37,7 +38,7 @@
         v-for="(meal, mealID) in day.meals"
         :key="mealID"
         class="mx-[15px] border-b-[0.7px] last:border-b-0"
-        :class="day.event !== null ? 'pt-[13px] pb-[13px] last:pb-0 last:pt-[21px]' : 'py-[13px]'"
+        :class="isEventDay ? 'pt-[13px] pb-[13px] last:pb-0 last:pt-[21px]' : 'py-[13px]'"
       >
         <VariationsData
           v-if="meal.variations"
@@ -60,11 +61,14 @@
     <div
       v-if="emptyDay || !day.isEnabled"
       class="z-[1] col-start-2 row-start-1 grid h-full min-w-[290px] items-center"
+      :class="isEventDay ? 'pt-[24px]' : ''"
     >
-      <span class="description relative ml-[23px] text-primary-1">{{ t('dashboard.no_service') }}</span>
+      <span class="description relative ml-[15px] text-primary-1">
+        {{ t('dashboard.no_service') }}
+      </span>
     </div>
     <EventData
-      v-if="day.event !== null"
+      v-if="isEventDay"
       class="col-start-2 row-start-2"
       :day="day"
     />

From c57e997a1f828631ac082357d5309ddde518aba8 Mon Sep 17 00:00:00 2001
From: Felix Ruf <felix.ruf@aoe.com>
Date: Thu, 18 Jan 2024 09:10:15 +0100
Subject: [PATCH 3/3] fixed cypress test

---
 tests/e2e/cypress/e2e/Dashboard.cy.ts | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git a/tests/e2e/cypress/e2e/Dashboard.cy.ts b/tests/e2e/cypress/e2e/Dashboard.cy.ts
index 08440f261..1e71e32fc 100644
--- a/tests/e2e/cypress/e2e/Dashboard.cy.ts
+++ b/tests/e2e/cypress/e2e/Dashboard.cy.ts
@@ -34,9 +34,8 @@ describe('Test Dashboard View', () => {
             .find('span')
             .contains('Afterwork')
             .parent()
-            .parent()
             .find('div')
-            .eq(1)
+            .eq(0)
             .find('div')
             .eq(1)
             .contains('span', '17')
@@ -240,9 +239,8 @@ describe('Test Dashboard View', () => {
             .find('span')
             .contains('Afterwork')
             .parent()
-            .parent()
             .find('div')
-            .eq(4)
+            .eq(3)
             .children()
             .should('have.length', 0);
 
@@ -258,9 +256,8 @@ describe('Test Dashboard View', () => {
             .find('span')
             .contains('Afterwork')
             .parent()
-            .parent()
             .find('div')
-            .eq(4)
+            .eq(3)
             .click();
 
         // confirm event has been joined
@@ -275,9 +272,8 @@ describe('Test Dashboard View', () => {
             .find('span')
             .contains('Afterwork')
             .parent()
-            .parent()
             .find('div')
-            .eq(4)
+            .eq(3)
             .children()
             .should('have.length', 1);
 
@@ -293,9 +289,8 @@ describe('Test Dashboard View', () => {
             .find('span')
             .contains('Afterwork')
             .parent()
-            .parent()
             .find('div')
-            .eq(4)
+            .eq(3)
             .click();
 
         // confirm event has been left
@@ -310,9 +305,8 @@ describe('Test Dashboard View', () => {
             .find('span')
             .contains('Afterwork')
             .parent()
-            .parent()
             .find('div')
-            .eq(4)
+            .eq(3)
             .children()
             .should('have.length', 0);
     });