Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "check" API / command #47

Open
commial opened this issue Aug 18, 2020 · 0 comments
Open

Add a "check" API / command #47

commial opened this issue Aug 18, 2020 · 0 comments
Labels
enhancement New feature or request mlar Concerns the mlar utility

Comments

@commial
Copy link
Contributor

commial commented Aug 18, 2020

For now, integrity checks are opt-out by default. Indeed, they potentially imply a costly additional content read.
One can already check for them, using the get_hash API, for each file.

It would be nice to have a dedicated helper in mla and a mlar check command, to easily check for:

  • Integrity of all files in the archive
  • Proper termination of the archive (presence of the EndOfArchiveData, meaning the file contents are not truncated)
  • Presence and readability of the footer, with a potential sanity check of it (does the raw information in the archive matches the footer?)

This would be a convenient way to easily ensure that an archive is readable on receive / before sending it.

Regarding the implementation in mla, a linear read is probably the best and faster method to achieve it.

@commial commial added enhancement New feature or request mlar Concerns the mlar utility labels Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mlar Concerns the mlar utility
Projects
None yet
Development

No branches or pull requests

1 participant