-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mh 2nd #96
Open
jackieyao0114
wants to merge
52
commits into
AMReX-Microelectronics:development
Choose a base branch
from
jackieyao0114:fix_MH_2nd
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix mh 2nd #96
jackieyao0114
wants to merge
52
commits into
AMReX-Microelectronics:development
from
jackieyao0114:fix_MH_2nd
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to development
…into development
…to development
…to development
…to development
…into development
…to development
…to development
…to development
Co-authored-by: Revathi Jambunathan <[email protected]>
Co-authored-by: Revathi Jambunathan <[email protected]>
Co-authored-by: Revathi Jambunathan <[email protected]>
Co-authored-by: Revathi Jambunathan <[email protected]>
…picProperties/MacroscopicProperties.cpp
…into development
…to development
…to development
…into development
…to development
…into development
…to development
…to development
…into development
…to development
…into development
…to development
…into development
…to development
…to development
…to development
…to development
…to development
…to development
…to development
…to development
…into development
…to development
…to development
…to development
…to development
…into development
prkkumar
approved these changes
Jun 2, 2022
…into fix_MH_2nd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mfield_old
instead ofMfield
to make it clear these are old (static) quantities.H_Bias
is time-varying, we really needH_bias_old
andH_bias_new
in the static and dynamic loops, respectively.Here is a demonstration case to show that the code works well after this PR. For details of the case setup, refer to Section 5.2.2 Magnetically tunable filter in our first paper https://journals.sagepub.com/doi/full/10.1177/10943420211057906 .
Here is the input file of this demo case: