From a9e47231d9c3cbfb3e904285598a670b2815b426 Mon Sep 17 00:00:00 2001
From: Bruce Perry <bruce.perry@nrel.gov>
Date: Wed, 9 Oct 2024 10:44:04 -0600
Subject: [PATCH] clang-tidy fixes

---
 Exec/RegTests/EB-Rotor4Blade/prob.H        | 4 ----
 Exec/RegTests/EB-Rotor4Blade/prob.cpp      | 4 ++--
 Exec/RegTests/EB-Rotor4Blade/prob_parm.H   | 4 ++--
 Exec/RegTests/EB-TaylorCouette/prob.H      | 4 ----
 Exec/RegTests/EB-TaylorCouette/prob.cpp    | 4 ++--
 Exec/RegTests/EB-TaylorCouette/prob_parm.H | 4 ++--
 6 files changed, 8 insertions(+), 16 deletions(-)

diff --git a/Exec/RegTests/EB-Rotor4Blade/prob.H b/Exec/RegTests/EB-Rotor4Blade/prob.H
index 822c0c856..de27fb5ef 100644
--- a/Exec/RegTests/EB-Rotor4Blade/prob.H
+++ b/Exec/RegTests/EB-Rotor4Blade/prob.H
@@ -44,10 +44,6 @@ pc_initdata(
   amrex::GeometryData const& geomdata,
   ProbParmDevice const& prob_parm)
 {
-  // Geometry
-  const amrex::Real* prob_lo = geomdata.ProbLo();
-  const amrex::Real* dx = geomdata.CellSize();
-
   amrex::Real u = 0.0;
   amrex::Real v = 0.0;
   amrex::Real w = 0.0;
diff --git a/Exec/RegTests/EB-Rotor4Blade/prob.cpp b/Exec/RegTests/EB-Rotor4Blade/prob.cpp
index 8287047cd..d08264a56 100644
--- a/Exec/RegTests/EB-Rotor4Blade/prob.cpp
+++ b/Exec/RegTests/EB-Rotor4Blade/prob.cpp
@@ -11,8 +11,8 @@ amrex_probinit(
   const int* /*init*/,
   const int* /*name*/,
   const int* /*namelen*/,
-  const amrex::Real* problo,
-  const amrex::Real* probhi)
+  const amrex::Real* /*problo*/,
+  const amrex::Real* /*probhi*/)
 {
   // Parse params
   amrex::ParmParse pp("prob");
diff --git a/Exec/RegTests/EB-Rotor4Blade/prob_parm.H b/Exec/RegTests/EB-Rotor4Blade/prob_parm.H
index 1572c8a77..7ddc4cbc5 100644
--- a/Exec/RegTests/EB-Rotor4Blade/prob_parm.H
+++ b/Exec/RegTests/EB-Rotor4Blade/prob_parm.H
@@ -14,9 +14,9 @@ struct ProbParmDevice
   amrex::Real mu = 0.1;
   amrex::Real kappa = 1.0;
   amrex::GpuArray<amrex::Real, NUM_SPECIES> massfrac = {1.0};
-  int do_rf = 0;
+  bool do_rf = 0;
   amrex::Real rf_omega = 0;
-  amrex::Real rf_axis = 2;
+  int rf_axis = 2;
   amrex::Real rf_axis_x = 0.0;
   amrex::Real rf_axis_y = 0.0;
   amrex::Real rf_axis_z = 0.0;
diff --git a/Exec/RegTests/EB-TaylorCouette/prob.H b/Exec/RegTests/EB-TaylorCouette/prob.H
index 822c0c856..de27fb5ef 100644
--- a/Exec/RegTests/EB-TaylorCouette/prob.H
+++ b/Exec/RegTests/EB-TaylorCouette/prob.H
@@ -44,10 +44,6 @@ pc_initdata(
   amrex::GeometryData const& geomdata,
   ProbParmDevice const& prob_parm)
 {
-  // Geometry
-  const amrex::Real* prob_lo = geomdata.ProbLo();
-  const amrex::Real* dx = geomdata.CellSize();
-
   amrex::Real u = 0.0;
   amrex::Real v = 0.0;
   amrex::Real w = 0.0;
diff --git a/Exec/RegTests/EB-TaylorCouette/prob.cpp b/Exec/RegTests/EB-TaylorCouette/prob.cpp
index 0c4101e42..3865b7bdb 100644
--- a/Exec/RegTests/EB-TaylorCouette/prob.cpp
+++ b/Exec/RegTests/EB-TaylorCouette/prob.cpp
@@ -11,8 +11,8 @@ amrex_probinit(
   const int* /*init*/,
   const int* /*name*/,
   const int* /*namelen*/,
-  const amrex::Real* problo,
-  const amrex::Real* probhi)
+  const amrex::Real* /*problo*/,
+  const amrex::Real* /*probhi*/)
 {
   // Parse params
   amrex::ParmParse pp("prob");
diff --git a/Exec/RegTests/EB-TaylorCouette/prob_parm.H b/Exec/RegTests/EB-TaylorCouette/prob_parm.H
index 1572c8a77..7ddc4cbc5 100644
--- a/Exec/RegTests/EB-TaylorCouette/prob_parm.H
+++ b/Exec/RegTests/EB-TaylorCouette/prob_parm.H
@@ -14,9 +14,9 @@ struct ProbParmDevice
   amrex::Real mu = 0.1;
   amrex::Real kappa = 1.0;
   amrex::GpuArray<amrex::Real, NUM_SPECIES> massfrac = {1.0};
-  int do_rf = 0;
+  bool do_rf = 0;
   amrex::Real rf_omega = 0;
-  amrex::Real rf_axis = 2;
+  int rf_axis = 2;
   amrex::Real rf_axis_x = 0.0;
   amrex::Real rf_axis_y = 0.0;
   amrex::Real rf_axis_z = 0.0;