You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We apparently don't consider a non-zero exit code a failure unless self.run_as_script is True. When doing plotfile comparisons, this isn't a big issue, since the comparison itself will fail as the test did not produce any output. However, when we run through travis we turn off comparisons, so we need to check the exit code.
An alternative fix would be to consider all non-zero exit codes a failure. In principle I prefer this, but I don't know the reasoning behind the original behavior here, so I'd like to be conservative.
The text was updated successfully, but these errors were encountered:
Potentially needs a backport from @atmyers in ECP-WarpX#1 :
The text was updated successfully, but these errors were encountered: