Skip to content

Commit f2adcb9

Browse files
committed
remove dabardt from the NSE output
we never use it and the interpolation can be expensive
1 parent 53d2621 commit f2adcb9

File tree

5 files changed

+0
-20
lines changed

5 files changed

+0
-20
lines changed

nse_tabular/nse_table.H

-2
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,6 @@ void nse_interp(nse_table_t& nse_state, bool skip_X_fill=false) {
431431
nse_state.abar = trilinear(ir1, it1, ic1, rholog, tlog, yet, abartab);
432432
nse_state.bea = trilinear(ir1, it1, ic1, rholog, tlog, yet, beatab);
433433
nse_state.dyedt = trilinear(ir1, it1, ic1, rholog, tlog, yet, dyedttab);
434-
nse_state.dabardt = trilinear(ir1, it1, ic1, rholog, tlog, yet, dabardttab);
435434
nse_state.dbeadt = trilinear(ir1, it1, ic1, rholog, tlog, yet, dbeadttab);
436435
nse_state.e_nu = trilinear(ir1, it1, ic1, rholog, tlog, yet, enutab);
437436

@@ -465,7 +464,6 @@ void nse_interp(nse_table_t& nse_state, bool skip_X_fill=false) {
465464
nse_state.abar = tricubic(ir0, it0, ic0, rholog, tlog, yet, abartab);
466465
nse_state.bea = tricubic(ir0, it0, ic0, rholog, tlog, yet, beatab);
467466
nse_state.dyedt = tricubic(ir0, it0, ic0, rholog, tlog, yet, dyedttab);
468-
nse_state.dabardt = tricubic(ir0, it0, ic0, rholog, tlog, yet, dabardttab);
469467
nse_state.dbeadt = tricubic(ir0, it0, ic0, rholog, tlog, yet, dbeadttab);
470468
nse_state.e_nu = tricubic(ir0, it0, ic0, rholog, tlog, yet, enutab);
471469

nse_tabular/nse_table_type.H

-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ struct nse_table_t {
1212
amrex::Real abar{};
1313
amrex::Real bea{};
1414
amrex::Real dyedt{};
15-
amrex::Real dabardt{};
1615
amrex::Real dbeadt{};
1716
amrex::Real e_nu{};
1817
amrex::Real X[NumSpec]{};

unit_test/nse_table_cell/nse_cell.H

-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ void nse_cell_c()
3030
std::cout << "Abar = " << abar << std::endl;
3131
std::cout << "<B/A> = " << dq << std::endl;
3232
std::cout << "dYe/dt = " << dyedt << std::endl;
33-
std::cout << "dAbar/dt = " << dabardt << std::endl;
3433
std::cout << "d<B/A>/dt = " << dbeadt << std::endl;
3534
for (int n = 0; n < NumSpec; ++n) {
3635
std::cout << "X(" << short_spec_names_cxx[n] << ") = " << X[n] << std::endl;

unit_test/test_nse_interp/ci-benchmarks/aprox19.out

-5
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ tricubic interpolated values:
3535
abar = 55.60652462
3636
bea = 8.755119523
3737
dyedt = -0.004527880871
38-
dabardt = 1.310223024e-16
3938
dbeadt = 0.000111945508
4039
e_nu = 1.101641642e+16
4140
X(H1) = 0
@@ -60,19 +59,15 @@ X(p) = 9.843630258e-06
6059

6160
testing temperature derivatives of cubic
6261
first finite-difference derivatives
63-
dAbar/dT = -1.072562355e-09
6462
dbea/dT = -6.867059575e-12
6563
now using derivative of the interpolant
66-
dAbar/dT = -1.072562604e-09
6764
dbea/dT = -6.867048589e-12
6865

6966

7067
testing density derivatives of cubic
7168
first finite-difference derivatives
72-
dAbar/drho = 3.987525411e-10
7369
dbea/drho = 7.619559936e-13
7470
now using derivative of the interpolant
75-
dAbar/drho = 3.987522836e-10
7671
dbea/drho = 7.618831514e-13
7772

7873
EOS T from e consistency check (old method): 1.395278886e+18 1.38844906e+18

unit_test/test_nse_interp/nse_cell.H

-11
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,6 @@ void nse_cell_c()
131131
std::cout << "abar = " << nse_state.abar << std::endl;
132132
std::cout << "bea = " << nse_state.bea << std::endl;
133133
std::cout << "dyedt = " << nse_state.dyedt << std::endl;
134-
std::cout << "dabardt = " << nse_state.dabardt << std::endl;
135134
std::cout << "dbeadt = " << nse_state.dbeadt << std::endl;
136135
std::cout << "e_nu = " << nse_state.e_nu << std::endl;
137136
for (int n = 0; n < NumSpec; ++n) {
@@ -161,18 +160,13 @@ void nse_cell_c()
161160

162161
nse_interp(nse_state);
163162

164-
std::cout << "dAbar/dT = " << (nse_state.abar - abar_old) / (nse_state.T - T_old) << std::endl;
165163
std::cout << "dbea/dT = " << (nse_state.bea - bea_old) / (nse_state.T - T_old) << std::endl;
166164

167165
std::cout << "now using derivative of the interpolant" << std::endl;
168166

169-
Real dabardT = nse_interp_dT(temperature, density, ye,
170-
nse_table::abartab);
171-
172167
Real dbeadT = nse_interp_dT(temperature, density, ye,
173168
nse_table::beatab);
174169

175-
std::cout << "dAbar/dT = " << dabardT << std::endl;
176170
std::cout << "dbea/dT = " << dbeadT << std::endl;
177171

178172
std::cout << std::endl;
@@ -196,18 +190,13 @@ void nse_cell_c()
196190

197191
nse_interp(nse_state);
198192

199-
std::cout << "dAbar/drho = " << (nse_state.abar - abar_old) / (nse_state.rho - rho_old) << std::endl;
200193
std::cout << "dbea/drho = " << (nse_state.bea - bea_old) / (nse_state.rho - rho_old) << std::endl;
201194

202195
std::cout << "now using derivative of the interpolant" << std::endl;
203196

204-
Real dabardrho = nse_interp_drho(temperature, density, ye,
205-
nse_table::abartab);
206-
207197
Real dbeadrho = nse_interp_drho(temperature, density, ye,
208198
nse_table::beatab);
209199

210-
std::cout << "dAbar/drho = " << dabardrho << std::endl;
211200
std::cout << "dbea/drho = " << dbeadrho << std::endl;
212201

213202
std::cout << std::endl;

0 commit comments

Comments
 (0)