remove sdc_burn_tol_factor

we never use this and it doesn't seem like it will be needed
since we've made so many improvements to the integrators.

Author: zingale

integration/BackwardEuler/actual_integrator_sdc.H

@@ -59,36 +59,34 @@ void actual_integrator (BurnT& state, const amrex::Real dt, bool is_retry=false)
 
     // Set the tolerances.
 
-    amrex::Real sdc_tol_fac = std::pow(integrator_rp::sdc_burn_tol_factor, state.num_sdc_iters - state.sdc_iter - 1);
-
     // we use 1-based indexing inside of BackwardEuler, so we need to shift the
     // indices SRHO, SFS, etc by 1
 
     amrex::Real sdc_min_density = amrex::min(state.rho, state.rho_orig + state.ydot_a[SRHO] * dt);
 
     if (!is_retry) {
 
-        be.atol_enuc = sdc_min_density * atol_enuc * sdc_tol_fac;
-        be.rtol_enuc = rtol_enuc * sdc_tol_fac;
+        be.atol_enuc = sdc_min_density * atol_enuc;
+        be.rtol_enuc = rtol_enuc;
 
         // Note: we define the input atol for species to refer only to the
         // mass fraction part, and we multiply by a representative density
         // so that atol becomes an absolutely tolerance on (rho X)
 
-        be.atol_spec = sdc_min_density * atol_spec * sdc_tol_fac;
-        be.rtol_spec = rtol_spec * sdc_tol_fac;
+        be.atol_spec = sdc_min_density * atol_spec;
+        be.rtol_spec = rtol_spec;
 
     } else {
 
-        be.atol_enuc = sdc_min_density * retry_atol_enuc * sdc_tol_fac;
-        be.rtol_enuc = retry_rtol_enuc * sdc_tol_fac;
+        be.atol_enuc = sdc_min_density * retry_atol_enuc;
+        be.rtol_enuc = retry_rtol_enuc;
 
         // Note: we define the input atol for species to refer only to the
         // mass fraction part, and we multiply by a representative density
         // so that atol becomes an absolutely tolerance on (rho X)
 
-        be.atol_spec = sdc_min_density * retry_atol_spec * sdc_tol_fac;
-        be.rtol_spec = retry_rtol_spec * sdc_tol_fac;
+        be.atol_spec = sdc_min_density * retry_atol_spec;
+        be.rtol_spec = retry_rtol_spec;
 
     }
 

integration/RKC/actual_integrator_sdc.H

@@ -58,36 +58,34 @@ void actual_integrator (BurnT& state, amrex::Real dt, bool is_retry=false)
 
     // Set the tolerances.
 
-    amrex::Real sdc_tol_fac = std::pow(sdc_burn_tol_factor, state.num_sdc_iters - state.sdc_iter - 1);
-
     // we use 1-based indexing inside of RKC, so we need to shift the
     // indices SRHO, SFS, etc by 1
 
     amrex::Real sdc_min_density = amrex::min(state.rho, state.rho_orig + state.ydot_a[SRHO] * dt);
 
     if (!is_retry) {
 
-        rkc_state.atol_enuc = sdc_min_density * atol_enuc * sdc_tol_fac;
-        rkc_state.rtol_enuc = rtol_enuc * sdc_tol_fac;
+        rkc_state.atol_enuc = sdc_min_density * atol_enuc;
+        rkc_state.rtol_enuc = rtol_enuc;
 
         // Note: we define the input atol for species to refer only to the
         // mass fraction part, and we multiply by a representative density
         // so that atol becomes an absolutely tolerance on (rho X)
 
-        rkc_state.atol_spec = sdc_min_density * atol_spec * sdc_tol_fac;
-        rkc_state.rtol_spec = rtol_spec * sdc_tol_fac;
+        rkc_state.atol_spec = sdc_min_density * atol_spec;
+        rkc_state.rtol_spec = rtol_spec;
 
     } else {
 
-        rkc_state.atol_enuc = sdc_min_density * retry_atol_enuc * sdc_tol_fac;
-        rkc_state.rtol_enuc = retry_rtol_enuc * sdc_tol_fac;
+        rkc_state.atol_enuc = sdc_min_density * retry_atol_enuc;
+        rkc_state.rtol_enuc = retry_rtol_enuc;
 
         // Note: we define the input atol for species to refer only to the
         // mass fraction part, and we multiply by a representative density
         // so that atol becomes an absolutely tolerance on (rho X)
 
-        rkc_state.atol_spec = sdc_min_density * retry_atol_spec * sdc_tol_fac;
-        rkc_state.rtol_spec = retry_rtol_spec * sdc_tol_fac;
+        rkc_state.atol_spec = sdc_min_density * retry_atol_spec;
+        rkc_state.rtol_spec = retry_rtol_spec;
 
     }
 

integration/VODE/actual_integrator_sdc.H

@@ -71,36 +71,34 @@ void actual_integrator (BurnT& state, amrex::Real dt, bool is_retry=false)
 
     // Set the tolerances.
 
-    amrex::Real sdc_tol_fac = std::pow(integrator_rp::sdc_burn_tol_factor, state.num_sdc_iters - state.sdc_iter - 1);
-
     // we use 1-based indexing inside of VODE, so we need to shift the
     // indices SRHO, SFS, etc by 1
 
     amrex::Real sdc_min_density = amrex::min(state.rho, state.rho_orig + state.ydot_a[SRHO] * dt);
 
     if (!is_retry) {
 
-        vode_state.atol_enuc = sdc_min_density * atol_enuc * sdc_tol_fac;
-        vode_state.rtol_enuc = rtol_enuc * sdc_tol_fac;
+        vode_state.atol_enuc = sdc_min_density * atol_enuc;
+        vode_state.rtol_enuc = rtol_enuc;
 
         // Note: we define the input atol for species to refer only to the
         // mass fraction part, and we multiply by a representative density
         // so that atol becomes an absolutely tolerance on (rho X)
 
-        vode_state.atol_spec = sdc_min_density * atol_spec * sdc_tol_fac;
-        vode_state.rtol_spec = rtol_spec * sdc_tol_fac;
+        vode_state.atol_spec = sdc_min_density * atol_spec;
+        vode_state.rtol_spec = rtol_spec;
 
     } else {
 
-        vode_state.atol_enuc = sdc_min_density * retry_atol_enuc * sdc_tol_fac;
-        vode_state.rtol_enuc = retry_rtol_enuc * sdc_tol_fac;
+        vode_state.atol_enuc = sdc_min_density * retry_atol_enuc;
+        vode_state.rtol_enuc = retry_rtol_enuc;
 
         // Note: we define the input atol for species to refer only to the
         // mass fraction part, and we multiply by a representative density
         // so that atol becomes an absolutely tolerance on (rho X)
 
-        vode_state.atol_spec = sdc_min_density * retry_atol_spec * sdc_tol_fac;
-        vode_state.rtol_spec = retry_rtol_spec * sdc_tol_fac;
+        vode_state.atol_spec = sdc_min_density * retry_atol_spec;
+        vode_state.rtol_spec = retry_rtol_spec;
 
     }
 

integration/_parameters

@@ -84,9 +84,6 @@ use_number_densities     bool     0
 # flag for tuning on the subtraction of internal energy
 subtract_internal_energy   bool     1
 
-# SDC iteration tolerance adjustment factor
-sdc_burn_tol_factor          real         1.e0
-
 # do we scale the ODE system we integrate to make it O(1)?
 # for Strang, this simply means scaling e by the initial energy?
 scale_system              bool         0