Merge branch 'development' into param_stuct

Author: zingale

.github/workflows/check_powi.yml

@@ -10,7 +10,7 @@ on:
       - development
 
 jobs:
-  check-ifdefs:
+  check-powi:
     runs-on: ubuntu-latest
 
     steps:
@@ -21,16 +21,7 @@ jobs:
       - name: Setup Python
         uses: actions/setup-python@v5
         with:
-          python-version: '3.10'
-
-      - name: Cache pip
-        uses: actions/cache@v4
-        with:
-          # this path is specific to Ubuntu
-          path: ~/.cache/pip
-          key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }}
-          restore-keys: |
-            ${{ runner.os }}-pip-
+          python-version: '3.11'
 
       - name: Run check_powi
         run: |

.github/workflows/docs-test.yml

@@ -19,16 +19,15 @@ jobs:
 
     steps:
       - uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
+
       - name: Install pandoc and doxygen
         run: |
           sudo apt install pandoc doxygen
 
       - name: Setup Python
         uses: actions/setup-python@v5
         with:
-          python-version: '3.10'
+          python-version: '3.11'
           cache: "pip"
 
       - name: Install dependencies

CHANGES.md

@@ -1,3 +1,15 @@
+# 24.05
+
+   * Runtime parameters can now be type `bool` (#1536)
+
+   * more clang-tidy and compiler warning cleaning (#1527 #1530,
+     #1532, #1533)
+
+   * Remove recursion in quicksort to avoid CUDA stack limits (#1531)
+
+   * Update the pynucastro networks to cache derived rate partition
+     functions (#1529)
+
 # 24.04
 
    * A new `test_screening_templated` unit test was added -- this

conductivity/stellar/actual_conductivity.H

@@ -80,10 +80,7 @@ actual_conductivity (T& state)
   amrex::Real ytot1     = 0.0e0_rt;
 
   // set the composition variables
-  amrex::Real w[6];
-  for (int i = 0; i < 6; i++) {
-    w[i] = 0.0e0_rt;
-  }
+  amrex::Real w[6] = {0.0};
 
   // the idea here is that w[0] is H, w[1] is He, and w[2] is metals
   for (int i = 0; i < NumSpec; i++) {

interfaces/eos_type.H

@@ -116,6 +116,12 @@ struct eos_rep_t:eos_base_t {
 #endif
 };
 
+struct eos_rh_t:eos_rep_t {
+    amrex::Real dhdr{};
+    amrex::Real dhdT{};
+    amrex::Real h{};
+};
+
 struct eos_extra_t:eos_t {
     amrex::Real dpdA{};
     amrex::Real dpdZ{};