Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player names used in score screen go missing if client disconnects #44

Open
AKMDM opened this issue Nov 7, 2016 · 1 comment
Open
Labels

Comments

@AKMDM
Copy link
Owner

AKMDM commented Nov 7, 2016

If a player disconnects usually before the score screen, their name will not be properly referenced and will print "Player [ID]" instead. This especially happens when the murderer, or the innocent who killed the murderer, leave before their names are printed onscreen.

To solve this, every player's name should be stored in a variable beforehand and updated in case they change their name in the middle of a round.

@AKMDM AKMDM added the bug label Nov 7, 2016
@prepper25
Copy link
Collaborator

prepper25 commented Nov 10, 2016

I guess that issue, happen when is trigged(deathplayer)the fadeout and start showing the score and exist a delay in that time, where is not saved the name of the player and show only his playerid.
One solution is save immediately his name when the murd is death or game over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants