From c4c85d3d693bd572a308c378bb184627c2d82269 Mon Sep 17 00:00:00 2001 From: kartikvirendrar Date: Wed, 24 Jul 2024 11:04:13 +0530 Subject: [PATCH 1/2] add suggestions to cache only if api returns non empty array --- package.json | 2 +- src/util/suggestions-util.ts | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/package.json b/package.json index 48b5190..9d511fe 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@ai4bharat/indic-transliterate", - "version": "1.3.5", + "version": "1.3.6", "description": "Transliterate component for React", "author": "AI4Bharat", "license": "MIT", diff --git a/src/util/suggestions-util.ts b/src/util/suggestions-util.ts index faba12f..504be00 100644 --- a/src/util/suggestions-util.ts +++ b/src/util/suggestions-util.ts @@ -111,10 +111,6 @@ export const getTransliterateSuggestions = async ( } else { if (showCurrentWordAsLastSuggestion) { const fallback = [word]; - cache[lang][word.toLowerCase()] = { - suggestions: fallback, - frequency: 1, - }; return fallback; } return []; From 83766528bed165e78faf3312f039ebfc370fe6e9 Mon Sep 17 00:00:00 2001 From: kartikvirendrar Date: Wed, 24 Jul 2024 12:05:22 +0530 Subject: [PATCH 2/2] add suggestions to cache only if api returns non empty array --- src/util/suggestions-util.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/suggestions-util.ts b/src/util/suggestions-util.ts index 504be00..12219a4 100644 --- a/src/util/suggestions-util.ts +++ b/src/util/suggestions-util.ts @@ -13,7 +13,7 @@ type CacheEntry = { const MAX_CACHE_SIZE = 10000; const SAVE_THRESHOLD = 20; -const CACHE_KEY = 'transliterateCache'; +const CACHE_KEY = 'transliterationCache'; const cache: Record> = loadCacheFromLocalStorage(); let newEntriesCount = 0;