Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposals #3

Open
guicho271828 opened this issue Jul 6, 2021 · 6 comments
Open

Proposals #3

guicho271828 opened this issue Jul 6, 2021 · 6 comments

Comments

@guicho271828
Copy link
Contributor

  • machine-readable specification of each generator, e.g. a json file for each generator, documenting the type, name, range of each argument, and the number of arguments
  • refactoring: same filename / directory hierarchy for every executable
  • refactoring: output name standardization
@haz
Copy link
Contributor

haz commented Jul 6, 2021

Couldn't we accomplish the same for 2/3 if 1 included specification of the running/generation?

Reason I ask is because this will likely be nestled in planutils on its way to a remote service -- the json manifest will require the parameters, how to run, what is produced, etc. All in machine readable format (since it will be exposed automatically by the planning-as-a-service server).

@jendrikseipp
Copy link
Collaborator

I think all three points would be nice to have, though 1 is definitely higher-priority than 2 and 3. And I agree with Christian that probably it's easiest to put everything into the specification.

@haz
Copy link
Contributor

haz commented Jul 7, 2021

Ya, so give us a chance to take a crack at the sophisticated manifest, and see how much of 1-2-3 we can knock off.

@jendrikseipp : What's the easiest way to start plugging away at 1? Just check into the source for things like this?

@jendrikseipp
Copy link
Collaborator

For our benchmarks generation paper, we have looked into parameter ranges a bit and I think Alvaro added some notes to README files. We'll try to integrate those soon. This should make it a bit easier to get started with some domains. But apart from that, yes, invoking the generator without arguments and hoping it prints a help message :-)

@jendrikseipp
Copy link
Collaborator

I started a project with similar goals: https://github.com/rleap-project/batch-pddl-generator It allows to define parameter ranges and then generate the Cartesian product of PDDL files. Importantly, the specification of each domain uses Python code. This allows to programmatically check for valid parameter combinations.

@guicho271828
Copy link
Contributor Author

Importantly, the specification of each domain uses Python code.

I would much prefer one that is language-agnostic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants