New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the maximum weight constant used in AMDN #151

Open

beckydvn opened this issue Aug 31, 2021 · 1 comment · Fixed by #140

Assignees

Labels

bug

Collaborator

beckydvn commented Aug 31, 2021

"WMAX" should be set to the maximum of all of the weights of the soft constraints
Keep the usage of WMAX consistent with the paper

beckydvn added the bug label

beckydvn self-assigned this

beckydvn linked a pull request

that will close this issue

Merged

Contributor

haz commented Dec 8, 2021

From authors:

I don't expect the result is the same if you make the w_max constraints “hard”, since the w_max is the max over all constraints. I would suggest you go ahead to try “the sum”

So the original was max, but sum might be interesting to try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment