Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool: validate SAS encoding wrt determinization #17

Open
ssardina opened this issue Jan 21, 2025 · 0 comments
Open

Tool: validate SAS encoding wrt determinization #17

ssardina opened this issue Jan 21, 2025 · 0 comments
Labels
type: feature request New feature or request

Comments

@ssardina
Copy link
Collaborator

Do you mean a utility in this repo that checks that a .sas file contains all the determinized actions of a domain? Kind of a "checker" that the translator used was good? Is that what you mean?

I do indeed. It's common for many FOND planners to use FD (of some sort) as a base. The test I would hope to use:

  1. Normalize + determinize the PDDL.
  2. Convert with the FD translator.
  3. Collect all the instances of operators in the SAS file.
  4. Cross reference so that if we have a ground instance of determinized action A in the SAS, we also have all of the other ground instances for the related outcomes of action A.

There may be some groundings that never happen (preconditions not reachable), but if you have one outcome in the SAS file, all the others should be there with the same grounding.

I'm starting to suspect that PRP+PR2+MyND+Paladinus all used the same assumption of --keep-unimportant-variables as their modified use to the FD translator, and I'm curious as to how benign or damaging that is, given the benchmarks we've come across. I've visualized most (if not all) of these domains, and haven't noticed wonky things like missing effects, and ditto with plan validation (naive grounding there means that we don't discard noop actions), but it's not impossible that we've been missing something for over a decade...

Originally posted by @haz in #16

@ssardina ssardina added the type: feature request New feature or request label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant