Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean domain files #5

Open
ssardina opened this issue Sep 22, 2024 · 2 comments
Open

Clean domain files #5

ssardina opened this issue Sep 22, 2024 · 2 comments

Comments

@ssardina
Copy link
Contributor

There seems to be several domain files in some cases, and many look like noise.

For example, let's take first-responders:

  • domain.pddl: seems to be original with lots of dummy non-used :requirements, like conditional effects
  • domain-fixed.pddl: same as domain.pddl but with just the used requirements, namely, :typing :negative-preconditions :non-deterministic
  • domain-fixed.pddl.fip: this seems to be the determinization that FIP used, it has lots of deterministic action versions, different signature of actions. I don't think it is good to keep planning specific encodings like this one.

I propose we try to aim for just one domain.pddl unless there is a good reason to keep multiple versions.

In this case, we should keep domain-fixed.pddl and rename it to just domain.pddl.

What do you think @haz ?

@ssardina
Copy link
Contributor Author

ssardina commented Sep 22, 2024

In fact, there are many domains coming from FIP with D_N prefixes like D_1_pick-up-from-table in BlocksWorld

I think we should clean them all up,. not relevant for this repo

@haz
Copy link
Contributor

haz commented Sep 23, 2024

Ya, that's a hold-over from the original PRP. FIP didn't (and still doesn't) come with a determinizer. So some of the domains you see are actually me reverse engineering what the non-det version should be, given the FIP manual action determinization :P.

Confirmed, we can remove those and just have the single unified one. This is especially ok now that fond-utils can create the determinized version FIP-style, if we should ever really need it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants