New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated structure #8

Open

krasnikov-andrew opened this issue Sep 11, 2018 · 2 comments

Contributor

krasnikov-andrew commented Sep 11, 2018

https://github.com/koorva/drawpixels/blob/ec2fcd29e30502f48a23a16d18f21619631c4a4f/drawpixels/src/drawpixels.cpp#L26-L36
https://github.com/koorva/drawpixels/blob/ec2fcd29e30502f48a23a16d18f21619631c4a4f/drawpixels/src/drawpixels.cpp#L467-L475
#7 I am not sure that its right. Maybe we should replace Point by FloatPoint?

Owner

AGulev commented Sep 19, 2018

Need to look into the code, I'll try to find time on the week.
Let's try to ping @britzl, maybe he wants to look into it too.

Owner

AGulev commented Sep 19, 2018 •

edited

Loading

I looked into it, and I think it looks good. If you need Float Point, why not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment