New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback to support VPC and improve readme #9

Open

3 of 4 tasks

lionelmace opened this issue Jun 30, 2022 · 1 comment

Collaborator

lionelmace commented Jun 30, 2022 •

edited by ADesprets

Loading

Feedback:
The README should describe what is created by the Shell script.

Move all scripts into script foler
Adapt script to support both Classic and VPC
In lib.sh add a line to support VPC

  #my_cluster_url=$(ibmcloud ks cluster get --cluster $my_ic_cluster_name --output json | jq -r .serverURL) # classic
  my_cluster_url=$(ibmcloud ks cluster get --cluster $my_ic_cluster_name --output json | jq -r .masterURL) # vpc

In provision_cluster-v2.sh, add a line to support VPC

#classic ingress_address=$(ibmcloud ks cluster get --cluster $my_ic_cluster_name --output json|jq -r .ingressHostname) #classic
  ingress_address=$(ibmcloud ks cluster get --cluster $my_ic_cluster_name --output json|jq -r .ingress.hostname) #vpc

The text was updated successfully, but these errors were encountered:

Owner

ADesprets commented Sep 8, 2022

We have started to improve the code to support both approach. We are just missing the file storage support on VPC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment