Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeviceLoader.cs - Not All Device Classes Considered #12

Open
martinsw opened this issue Jul 11, 2017 · 2 comments
Open

DeviceLoader.cs - Not All Device Classes Considered #12

martinsw opened this issue Jul 11, 2017 · 2 comments

Comments

@martinsw
Copy link
Contributor

On http://dictionary.isobus.net/isobus/dDEntity you can see device classes 17 to 26 which aren't considered in GetMachineType yet.
@knelson-farmbeltnorth
Copy link
Contributor

Martin, I've added support for everything except #26 (for which you may have noticed I added a new Framework issue), and types 19-23 which appear to be related exclusively to Forestry equipment. We should discuss if these belong in ADAPT.

I'm unable to find a definition for type 18. Can you advise on its meaning?

@martinsw
Copy link
Contributor Author

Hi Kelly, 18 is 'Reserved for Future Assignment' - so nothing we need to consider today.
Maybe you want to rethink to exclude 23 Mulchers. They are quite frequently used on farms for landscape work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martinsw @knelson-farmbeltnorth