Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task 6: Submit PR for raised issue [Optional] #127

Open
lisa761 opened this issue Apr 19, 2020 · 0 comments
Open

Task 6: Submit PR for raised issue [Optional] #127

lisa761 opened this issue Apr 19, 2020 · 0 comments

Comments

@lisa761
Copy link
Member

lisa761 commented Apr 19, 2020

For the sake of consistency, we are adding this task here to keep a check on all the PRs that are being submitted for closing the issues that were submitted for Task 5.

In this task, you will submit a final PR that solves the issue that you have raised for the previous task. So make sure you have finished the previous task before you proceed with this.

Note: This task will not have any score since it's optional and is in regards to solving bugs in this repository, which will obviously be related to Web Development.

Since there are no marks for this, you are free to take as much time as you need to submit the PR.

And also, don't forget to add resolves #<your issue number> in your PR description so that when your PR gets merged, it automatically closes your issue.

It is recommended to discuss the implementation in the issue itself before submitting a PR so that we can know what to expect.

Reminder: It might take some time before you get a review, so have patience :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant