Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial Changes to spack.yaml Require Rebuild of Some Packages #12

Open
CodeGat opened this issue Sep 23, 2024 · 7 comments
Open

Trivial Changes to spack.yaml Require Rebuild of Some Packages #12

CodeGat opened this issue Sep 23, 2024 · 7 comments

Comments

@CodeGat
Copy link
Member

CodeGat commented Sep 23, 2024

Currently, doing trivial modifications to the spack.yaml (seen most prominently in #5) require rebuilding parallelio, esmf and (therefore) access-om3-nuopc. This is a bit of a time sink since esmf can take upwards of 1/2 an hour.

See the following runs, in which nothing was changed relating to the above packages: https://github.com/ACCESS-NRI/ACCESS-OM3/actions/runs/10987685371/job/30502929361?pr=5#step:8:767, https://github.com/ACCESS-NRI/ACCESS-OM3/actions/runs/10985399681/job/30497188155#step:8:773.

Determine if the current spack.packages.*.require statements are not restrictive enough to prevent a rebuild - https://github.com/ACCESS-NRI/ACCESS-OM3/pull/5/files#diff-e8582e74fa156f4e5729a850e52b24f2fde2d815c2c9c360f88c4cf90db851abR10-R20

Or maybe it's another problem?

@harshula
Copy link
Collaborator

Double check if the Spack hash is the same or if it has changed.

@CodeGat
Copy link
Member Author

CodeGat commented Sep 23, 2024

parallelio, esmf, access-om3-nuopc do change between runs.

@anton-seaice
Copy link
Contributor

anton-seaice commented Sep 23, 2024

Both esmf and access-om3-nuopc have dependencies on parallelio (e.g. https://github.com/spack/spack/blob/c118c7733b9e20f079bb19b84b8ad60cacd2a673/var/spack/repos/builtin/packages/esmf/package.py#L91), so i'd guess its related to parallelio or one of its deps

@CodeGat
Copy link
Member Author

CodeGat commented Oct 18, 2024

Another avenue is the spack gc garbage collection that happens on removal of old Prerelease environments as part of on.pull_request.types.closed, see https://github.com/ACCESS-NRI/ACCESS-OM2/actions/runs/11396341321/job/31710012054#step:6:18

@CodeGat
Copy link
Member Author

CodeGat commented Feb 5, 2025

Due to chats with spack devs, it might be useful to check the difference between the hashes with spack diff /HASH1 /HASH2

@anton-seaice
Copy link
Contributor

I don't know what this tells us :-)

spack diff /qcd4giqfkytonx3kmqkjwrfat3kiogai /pj4c37ym76pt3eaqqypzgtxl5rqkve7l
==> Warning: This interface is subject to change.

--- [email protected]/qcd4giqfkytonx3kmqkjwrfat3kiogai
+++ [email protected]/pj4c37ym76pt3eaqqypzgtxl5rqkve7l
@@ hash @@
-  parallelio qcd4giqfkytonx3kmqkjwrfat3kiogai
+  parallelio pj4c37ym76pt3eaqqypzgtxl5rqkve7l

@anton-seaice
Copy link
Contributor

Lots of noise ...

But I have parallelio installed, do a concretise and it decides I need a new one (note - next to parallelio) :

[as2285@gadi-login-03 spack0.22]$ spack find parallelio
==> In environment cice-spack-package
==> 1 root specs
 -  [email protected]=0-git.14

==> Installed packages
-- linux-rocky8-x86_64 / [email protected] ------------------------
[email protected]
==> 1 installed package
[as2285@gadi-login-03 spack0.22]$ spack concretise -f --fresh
==> Warning: using "[email protected]" which is a deprecated version
==> Concretized [email protected]=0-git.14
 -   b26hvt5  [email protected]=0-git.14%[email protected] build_system=bundle arch=linux-rocky8-x86_64
 -   apv4p3o      ^[email protected]=0-git.171%[email protected]~ipo~openmp build_system=cmake build_type=Release configurations=CICE6,MOM6-CICE6 dev_path=/g/data/tm70/as2285/spack0.22/environments/cice-spack-package/access3-share generator=make arch=linux-rocky8-x86_64
 -   gtx27bo          ^[email protected]_cmake_build=6.2.0-git.203%[email protected]+access3+cesmcoupled~ipo build_system=cmake build_type=Release dev_path=/g/data/tm70/as2285/spack0.22/environments/cice-spack-package/access-cice generator=make io_type=PIO arch=linux-rocky8-x86_64
 -   rje7cyo              ^[email protected]=0-git.171%[email protected]~ipo build_system=cmake build_type=Release dev_path=/g/data/tm70/as2285/spack0.22/environments/cice-spack-package/access3-share generator=make arch=linux-rocky8-x86_64
 -   gvv2k6y                  ^[email protected]=8.7.0%[email protected] cflags='-fp-model precise' fflags='-traceback -fp-model precise' ~debug~external-lapack+external-parallelio+mpi+netcdf~pnetcdf+shared~xerces build_system=makefile esmf_comm=auto esmf_os=auto esmf_pio=auto patches=f63d405 snapshot=none arch=linux-rocky8-x86_64
[+]  bcbruwv                  ^[email protected]%[email protected] build_system=autotools arch=linux-rocky8-x86_64
 -   pm7t3uw              ^[email protected]%[email protected] cflags='-std=gnu99 -qno-opt-dynamic-align -fp-model precise' fflags='-convert big_endian -ftz -assume realloc_lhs -assume byterecl -qno-opt-dynamic-align -fp-model source -traceback' +fortran~ipo~logging+mpi~ncint~pnetcdf+shared~timing build_system=cmake build_type=RelWithDebInfo generator=make arch=linux-rocky8-x86_64
[+]  2c4wu5t                  ^[email protected]%[email protected]+blosc~byterange~dap~fsync~hdf4~ipo~jna+mpi~nczarr_zip+optimize~parallel-netcdf+pic+shared+szip+zstd build_system=cmake build_type=RelWithDebInfo generator=make patches=0161eb8 arch=linux-rocky8-x86_64
[+]  357vng5                      ^[email protected]%[email protected]~debug~pic+shared build_system=generic arch=linux-rocky8-x86_64
[+]  y7n7vkn                          ^[email protected]%[email protected] build_system=autotools arch=linux-rocky8-x86_64
[+]  55ipnye                              ^[email protected]%[email protected] build_system=autotools libs=shared,static arch=linux-rocky8-x86_64
[+]  jdlivnc                      ^[email protected]%[email protected]+avx2~ipo build_system=cmake build_type=RelWithDebInfo generator=make arch=linux-rocky8-x86_64
[+]  7a5olrr                          ^[email protected]%[email protected]+pic build_system=makefile libs=shared,static arch=linux-rocky8-x86_64
[+]  ju23cym                          ^[email protected]%[email protected]~ipo+pic+shared build_system=cmake build_type=RelWithDebInfo generator=make arch=linux-rocky8-x86_64
[+]  ozfo7fd                      ^[email protected]%[email protected]~cxx~fortran+hl~ipo~java~map+mpi+shared~subfiling~szip~threadsafe+tools api=default build_system=cmake build_type=RelWithDebInfo generator=make patches=82088c8 arch=linux-rocky8-x86_64
[+]  vrupasu                          ^[email protected]%[email protected] build_system=autotools arch=linux-rocky8-x86_64
[+]  675weom                      ^[email protected]%[email protected]~ipo+shared build_system=cmake build_type=RelWithDebInfo generator=make arch=linux-rocky8-x86_64
[+]  rglvnt5                      ^[email protected]%[email protected]+sigsegv build_system=autotools patches=9dc5fbd,bfdffa7 arch=linux-rocky8-x86_64
[+]  ou7jkjx                          ^[email protected]%[email protected] build_system=autotools arch=linux-rocky8-x86_64
[+]  wa2x7rh                      ^[email protected]%[email protected]+compat+new_strategies+opt+pic+shared build_system=autotools arch=linux-rocky8-x86_64
[+]  kzc7pcv                      ^[email protected]%[email protected]~programs build_system=makefile libs=shared,static arch=linux-rocky8-x86_64
 -   xo3zqcq          ^[email protected]_build=0-git.11338%[email protected]+access3+cesmcoupled~ipo+mom_symmetric~openmp build_system=cmake build_type=Release dev_path=/g/data/tm70/as2285/spack0.22/environments/cice-spack-package/MOM6 generator=make arch=linux-rocky8-x86_64
[+]  on4aolu              ^[email protected]=2024.01.02-git.26%[email protected]~deprecated_io~gfs_phys+internal_file_nml~ipo+large_file~openmp~pic~quad_precision~yaml build_system=cmake build_type=RelWithDebInfo constants=GFDL generator=make precision=32,64 arch=linux-rocky8-x86_64
[+]  bky2d7s              ^[email protected]%[email protected]~doc+pic+shared build_system=autotools arch=linux-rocky8-x86_64
[e]  tkmozao          ^[email protected]%[email protected]~doc+ncurses+ownlibs build_system=generic build_type=RelWithDebInfo arch=linux-rocky8-x86_64
[+]  doeoclg          ^[email protected]%[email protected]~guile build_system=generic arch=linux-rocky8-x86_64
[e]  5kn4pgy          ^[email protected]%[email protected]~atomics~cuda~cxx~cxx_exceptions~gpfs~internal-hwloc~internal-libevent~internal-pmix~java~legacylaunchers~lustre~memchecker~openshmem~orterunprefix~romio+rsh~singularity~static+vt+wrapper-rpath build_system=autotools fabrics=none romio-filesystem=none schedulers=none arch=linux-rocky8-x86_64
[e]  5elnsoi      ^[email protected]%[email protected] build_system=autotools arch=linux-rocky8-x86_64

==> Updating view at /g/data/tm70/as2285/spack0.22/environments/cice-spack-package/.spack-env/view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants