Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop go dependency ? #1

Open
cmdoret opened this issue Nov 30, 2022 · 2 comments
Open

drop go dependency ? #1

cmdoret opened this issue Nov 30, 2022 · 2 comments

Comments

@cmdoret
Copy link

cmdoret commented Nov 30, 2022

Hi @ABignaud, I noticed you are using dnaglider in your smk workflow 😁
Unfortunately I did not make it into a conda package, which is a shame because Go is only required to compile it (and not run it).

As I don't have time to make a go pkg now, maybe a more convenient alternative for you would be seqkit, another go package which is on bioconda.

Here:

go get -u github.com/cmdoret/dnaglider/dnaglider
dnaglider \
-fasta {input.fasta} \
-fields GC \
-out {output.gc} \
-stride 100 \
-threads {threads} \
-window 500

You could have something like this instead:

seqkit sliding --step 100 --window 500 W303_SGD_2015_JRIU00000000.fa.gz | seqkit fx2tab --gc | cut -f1,4

gi|696447993|gb|JRIU01000414.1|_sliding:901-1400	38.80
gi|696447993|gb|JRIU01000414.1|_sliding:1001-1500	38.80
gi|696447993|gb|JRIU01000414.1|_sliding:1101-1600	38.60
gi|696447993|gb|JRIU01000414.1|_sliding:1201-1700	38.60
gi|696447993|gb|JRIU01000414.1|_sliding:1301-1800	38.80
gi|696447993|gb|JRIU01000414.1|_sliding:1401-1900	39.80
gi|696447993|gb|JRIU01000414.1|_sliding:1501-2000	40.00
gi|696447993|gb|JRIU01000414.1|_sliding:1601-2100	39.80

This would allow you to just add seqkit to the conda env and drop go from dependencies

@ABignaud
Copy link
Owner

Yes I agree it would have been better to avoid the dependency issues. I just start to do the workflow to compile the analysis pipelines I used to generates the figures for the paper. I used the output of dnaglider to generate the GC file (outside the workflow at the beginning) used in the analysis so that's why I used it in the rule even if the dependency is painful.

@cmdoret
Copy link
Author

cmdoret commented Nov 30, 2022

Makes sense, I added an issue on cmdoret/dnaglider#4 (comment) I am not sure when I will have time to make a conda package, but providing a dockerfile should be fairly simple (and better than nothing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants