Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the HOSPITALS file #21

Open
edengby opened this issue Apr 27, 2023 · 3 comments
Open

Update the HOSPITALS file #21

edengby opened this issue Apr 27, 2023 · 3 comments

Comments

@edengby
Copy link

edengby commented Apr 27, 2023

If I want to add values to the HOSPITALS, how it should be done?
(hebsafeharbor/lexicons/hospital_lexicon.py)
I noticed that the code is not referenced. How come?
I tried running the docker-compose-development build and up but it did not change the list to recognize the new values.

@edengby edengby closed this as completed Apr 27, 2023
@edengby edengby reopened this Apr 27, 2023
@omri374
Copy link
Contributor

omri374 commented Apr 30, 2023

Looks like the hospitals lexicon isn't used by default. I would suggest to add it to the PhiIdentifier class similarly to how diseases and medications are handled.
First, add it to the imports here:

from hebsafeharbor.lexicons.medications import MEDICATIONS

Then, instantiate it similar to this:

Hope this helps

@edengby
Copy link
Author

edengby commented Apr 30, 2023

Thank you for the quick response.
If I'm not mistaken, the diseases and medications are not anonymized by default.
What else should be changed?
Example of run (took from lexicons files):

גדעון לבנה הגיע היום לבית החולים שערי צדק עם תלונות על כאבים בחזה קיבל אנטיטריפסין והרספטין בנוסף אובחן עם רגל שטוחה ללא היסטוריה קודמת

image

@omri374
Copy link
Contributor

omri374 commented May 2, 2023

I haven't tested it but adding it to the ner_signals should be adding it to the detection pipeline. Perhaps the confidence score is too low and causing some results to be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants