-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enalbling frozenColumn disables cell range selection #336
Comments
Can you please use latest code, PR #331 got merged yesterday to fix a cell range issue (#329) with frozen grids (with |
I am pretty sure, that right now, I have the latest version of the code base... |
Actually the error came from the |
Found the issue, the new PR has 2 new variables which were not initialized causing Can you please try again, I fixed and merged the code |
Yes, both issues are now fixed, great! Works without the "frozenRow" workaround and I do not get the JS error in the console anymore (it was driving me crazy, why it worked in my jsfiddle (where scrollbars were visible) and not in my local development version (where I had only horizontal scrolling or no at all). |
Good thanks for the feedback 😉 Also note that we'll be releasing a new version on NPM in the coming days, we were just waiting to see if anything came up with latest PRs... and you found an issue, so thanks for reporting :) |
As stated here #26 (comment) enabling frozen columns should make also cell range selection working (again).
But I tried a simple example where cell range selection works until I activate frozenColumn. Then it selects only one the first cell clicked and does not select the other (dragged over).
I have also created a detailed StackOverflow post with an jsfiddle example here: https://stackoverflow.com/questions/54574757/enalbling-frozencolumn-disables-cell-range-selection
EDIT / UPDATE
Maybe important info: I just updated my local copy of the repository and now, if I drag to select cells with frozenColumns activated, I get an error:
slick.cellrangedecorator.js:51 Uncaught TypeError: Cannot read property 'top' of null
at CellRangeDecorator.show (slick.cellrangedecorator.js:51)
at SlickGrid.handleDragStart (slick.cellrangeselector.js:115)
at Event.notify (slick.core.js:147)
at trigger (slick.grid.js:2029)
at HTMLDivElement.handleDragStart (slick.grid.js:3854)
at HTMLDivElement.dispatch (jquery-1.11.2.min.js:3)
at HTMLDivElement.$event.dispatch (jquery.event.drag-2.3.0.js:382)
at HTMLDivElement. (jquery.event.drag-2.3.0.js:267)
at Function.each (jquery-1.11.2.min.js:2)
at m.fn.init.each (jquery-1.11.2.min.js:2)
The text was updated successfully, but these errors were encountered: