Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review / Refactor the parsers. #7

Open
o0Ignition0o opened this issue Jun 28, 2019 · 0 comments
Open

Review / Refactor the parsers. #7

o0Ignition0o opened this issue Jun 28, 2019 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@o0Ignition0o
Copy link
Contributor

o0Ignition0o commented Jun 28, 2019 •
edited
Loading

I haven't taken a thorough look at the Nom documentation just yet, so the parsers are pretty messy for now.

There's probably a lot of low hanging fruits to grab. But I have no idea which ones.
If anyone has a bit of experience with Nom, I would love to discuss how to write more elegant parsers in this issue.
I would of course love to review pull requests if anyone would rather like to submit code instead of a code review :)
@o0Ignition0o o0Ignition0o added the help wanted Extra attention is needed label Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@o0Ignition0o