Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contact's phone number menu not working on iOS 16.x #429

Closed
heathermh opened this issue Jan 24, 2024 · 9 comments · Fixed by #446
Closed

contact's phone number menu not working on iOS 16.x #429

heathermh opened this issue Jan 24, 2024 · 9 comments · Fixed by #446
Milestone

Comments

@heathermh
Copy link
Collaborator

When I tap the menu to see additional office phone numbers for a contact, the menu comes up blank. This only seems to happen on hardware. I'm testing with iPad 6th gen on iPadOS 16.2. The behavior in simulator is different, and also different from within Xcode.

@nickoneill
Copy link
Member

I don't have a hardware iPad on 16.2, but fwiw the copy menu works fine on a 17.x iPad.

@heathermh
Copy link
Collaborator Author

@nickoneill Confirmed it's fine with an iOS update. I'm OK with letting it go if you are.

@nickoneill
Copy link
Member

Yep, shouldn't be a blocker for right now. Let's keep the issue around for fixing in a future release

@nickoneill nickoneill added this to the Future release milestone Jan 26, 2024
@nickoneill
Copy link
Member

A user reported this on an iPhone 12 with iOS 16.3.1

@cselin
Copy link
Collaborator

cselin commented Feb 12, 2024

Not seeing it with iPad (simulator) on 16.4. I'm downloading 16.2 for iPhone 12 sim, but it looks like 16.3 isn't available. Will see if I can repro and fix.

@nickoneill
Copy link
Member

The user reported it with CA senators which work fine for me in a 16.4 sim for iPhone 12, I can pick up a refurb iPhone 8 somewhere if we really can't get it to appear in the sims.

@cselin
Copy link
Collaborator

cselin commented Feb 12, 2024

I am seeing an issue on the iPhone 12 simulator in 16.2 although not sure if it's the same. Tapping the "..." doesn't appear to do anything so I can get going on a fix for that and see if they menu renders correctly. I also noticed the welcome screen is broken, which I wrote up separately here: #443

@cselin
Copy link
Collaborator

cselin commented Feb 12, 2024

I'm having a hard time debugging on older OS's, breakpoints aren't getting hit, etc. We could build out an alternative UX for 16.3 and under, but I'm wondering how large that user base is and whether it is worth special casing, especially because 2.0 only works on 16.0+ anyway.

[Update] Also worth mentioning, I can repro on iPad/iPhone 16.2, but not on iPad/iPhone 16.4

@cselin cselin linked a pull request Feb 24, 2024 that will close this issue
@cselin
Copy link
Collaborator

cselin commented Feb 24, 2024

I noticed a few people mentioning this in App Store reviews so I found a fix.

@nickoneill nickoneill changed the title contact's phone number menu not working on ipad contact's phone number menu not working on iOS 16.x Feb 25, 2024
@nickoneill nickoneill modified the milestones: Future release, 2.0.2 Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants