Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wind thresholds changed recently #20

Open
rawrbooks opened this issue Jan 11, 2022 · 11 comments
Open

Wind thresholds changed recently #20

rawrbooks opened this issue Jan 11, 2022 · 11 comments
Assignees

Comments

@rawrbooks
Copy link
Collaborator

Hi,

I and others in my discord server have noticed that the game has changed how it accounts for gusts -- either pulling wind based solely on gust speed or something else about how it relates to overall wind speed. Regardless, I'm now getting lots of "phantom wind", wind that shows up in-game but not in the bot. I'm down to do some documentation in order to figure out exactly what has shifted, if y'all could change the code so that it uses a more accurate variable. Could someone partner with me for it?

@5310
Copy link
Owner

5310 commented Jan 12, 2022

Hullo there! Let me make a branch for you for testing and observations: v2-webhook-rawrbooks

Most of 2021 I myself got a lot of unexpected wind, and it was pretty accurate, but then winter happened (when we normally get a lot of wind IRL) and neither the game nor the bot has said it'd be windy. It's very rare here, so I'm glad you're looking into it again.

I'll give you edit access to the branch, but you an also tell me what changes to the current thresholds or formula you want to make to start with and I'll edit it in.

@rawrbooks
Copy link
Collaborator Author

hi!! thank you! I actually am in the very beginning stages of learning to code, so not sure that I'd be able to help with edits, but I can certainly track my weather and in-game responses to try and get an idea of where the pull formula might have changed. I'll tap a few friends to try and come up with hypotheses of what's happening too! I'll make a note to follow up in a couple weeks and see what data I can gather in the meantime, but I had some phantom wind yesterday where it was supposed to be partly cloudy and was windy instead lol.

@ajstewart
Copy link
Collaborator

I'd be happy to also look over any data you get. It's always the nicer side of the problem if wind is happening in-game but not predicted by the current model!

I am not much help at the moment 😅:
pogo-weather

@rawrbooks
Copy link
Collaborator Author

rawrbooks commented Feb 12, 2022 via email

@5310
Copy link
Owner

5310 commented Feb 13, 2022

Honestly, I gave up trying to estimate the pull times completely...

In my region I've never noticed the pulls update more than once in an hour on the hour. But AJ has observed them changing within the hour more than once, and so much of it is still in the air 🥲

In my case, the updates happened anything from 10 to 15 minutes after the hour. Which I found out by querying every five minutes for an hour, and noting when they actually updated. Since they update only once, even that fuziness of when the data actually shows up in a query wasn't enough to worry about. I just let the bot pull in the middle of the hour.

@rawrbooks
Copy link
Collaborator Author

rawrbooks commented Feb 13, 2022 via email

@ajstewart
Copy link
Collaborator

Yes I have done an experiment before where I have observed the wind speed predictions changing within the hour that has the possibility to affect the forecast, but I'd be surprised if this was a consistent problem. I gave up a while ago now trying to predict the actual pull time, I notice now and then that the forecast still lags behind by a number of hours (rain is very helpful with that as it overrides the wind). But that combined with the minute of the pull, the uncertainty that we are actually using the correct Accuweather location etc etc makes it pretty painful to try and nail down. I settled on :35 for the pull and left it at that.

It's interesting that you have no wind prediction at all though and wind in game. I haven't monitored much myself in recent times but I always had the problem the other way around - predicting wind when it never came. There was always a feeling that there was an upper gust limit that would trigger it but I was never able to see this in my own data conclusively.

But yes this was all a while ago now so it absolutely could have changed!

@rawrbooks
Copy link
Collaborator Author

rawrbooks commented Feb 14, 2022 via email

@ajstewart
Copy link
Collaborator

The relevant logic is here:

const thresholds = {
dominant: {
wind: 20,
gust: 30,
},
superficial: {
// rain: 50,
// snow: 50,
wind: 16,
},
}
const aw2pogo = ({
label,
wind,
gust,
}) => {
const weather = weatherMap[label] ?? { dominant: 'unknown', superficial: {}, windyable: false }
const windy = wind > thresholds.dominant.wind && gust > thresholds.dominant.gust
const dominant = weather.windyable && windy ? 'windy' : weather.dominant
return {
dominant,
superficial: {
...weather.superficial,
windy: dominant !== 'windy' && (!weather.windyable && (windy || wind) >= thresholds.superficial.wind)
},
}
}

Line 173 is the windy decision.

However on my instance I run the gust threshold as 29.6, not 30 as is used here in line 158.

@rawrbooks
Copy link
Collaborator Author

rawrbooks commented Feb 15, 2022 via email

@FuzionEcho
Copy link

Hello!, so I've been trying to run this on my discord server, but I can't quite seem to be able to grasp how to is there any way you can make a video tutorial on how to do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants