Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mongo-shell CLI option to the base CLI command #215

Open
3 tasks
Lysoun opened this issue Oct 3, 2023 · 0 comments
Open
3 tasks

Move mongo-shell CLI option to the base CLI command #215

Lysoun opened this issue Oct 3, 2023 · 0 comments
Labels
breaking-change cli Concerning the CLI use enhancement New feature or request good first issue Good for newcomers

Comments

@Lysoun
Copy link
Member

Lysoun commented Oct 3, 2023

Currently:
The mongo-shell option is only available in the subcommand update-db. The two other commands, list and mark-one-script-as-executed can't use a specified mongo shell, they only use the default shell, which is mongosh.

Expected:

  • Move the mongo shell CLI option to Datamaintain
  • Update the tests for update-db (in UpdateDbTest) to no longer test that the mongo shell is accurate
  • Update the tests for Datamaintain (in DatamaintainTest) to ensure that this now option is read from the shell, read from the configuration file and correctly overriden when given in shell and configuration file

⚠️ This could break the tests in MongoIT and many CLI tests because of the order of the arguments. To run the MongoIT tests, you could need both versions of mongo shell, mongo and mongosh

@Lysoun Lysoun added enhancement New feature or request good first issue Good for newcomers cli Concerning the CLI use breaking-change labels Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change cli Concerning the CLI use enhancement New feature or request good first issue Good for newcomers
Projects
Status: To do
Development

No branches or pull requests

1 participant