Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D Particles emitter created from scratch cause preview to crash #7213

Open
1 task done
ddabrahim opened this issue Nov 30, 2024 · 1 comment
Open
1 task done

3D Particles emitter created from scratch cause preview to crash #7213

ddabrahim opened this issue Nov 30, 2024 · 1 comment

Comments

@ddabrahim
Copy link
Contributor

ddabrahim commented Nov 30, 2024

Is there an existing issue for this?

Describe the bug

When you create a 3D particles emitter from scratch and create an instance in the scene, it is cause the preview to crash.

The cause of the crash is that unlike the 2D particles emitter the 3D particles emitter comes with no default image when created from scratch and if you don't set one, it is cause the preview to crash because unable to load image.

Now we can consider this a "feature" that require users to make sure they set an image when they create a particles emitter from scratch, but in my opinion it should not crash the preview and I think it should come with a default image.

Also when we are editing a cloud project and we choose to "+Add sprite" in the particles emitter properties, it is opens the last used directory in our filesystem which may not include images we want. I think it should display images we already have in our project with an option to add a new image from filesystem.

At minimum it should display a warning, "no image is set" because I didn't notice. Lately I use GDevelop on my iPhone and iPad with a cloud project and I didn't notice it comes with no image at first. I have noticed only now as I was debug it on macOS.

Thank you.

Steps to reproduce

  1. Create a cloud project
  2. Create a 3D particles emitter from scratch
  3. Add no image and save it
  4. Create an instance in the scene
  5. Run preview it should crash.
  6. Edit particles emitter object
  7. Choose to "+Add sprite"
  8. As it is a cloud project, it is going to open a directory you have opened before.

GDevelop platform

Desktop, Mobile

GDevelop version

5.4.218

Platform info

OS (e.g. Windows, Linux, macOS, Android, iOS)
macOS, iOS, iPadOS

OS Version (e.g. Windows 10, macOS 10.15)
macOS 15.1.1
iOS 18.1.1
iPadOS 18.1.1

Additional context

No response

@ClementPasteau
Copy link
Collaborator

Thanks for the report on this @ddabrahim

Wether an image is displayed or not, it should not crash the preview indeed.
Here is a more detailed error of what happens
image

@D8H any chance you could look into it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants