Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor crash - Manipulating a Pixi object after it being destroyed (reading 'valid') #5896

Closed
MgamingRblx opened this issue Nov 11, 2023 · 3 comments · Fixed by #6926
Closed
Labels
💥crash Bug that is crashing the software

Comments

@MgamingRblx
Copy link

Describe what you were doing when the crash happened

i clicked in one of the button of my game and the screen popped up

GDevelop version

5.3.180-4f98ffa9ab98b751f6526f4d8ac28cef0c16ed1e

Platform info

System Version: Unknown system version (web-app), Arch: Unknown architecture (web-app), User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36, Platform: Win32

Additional error context

TypeError: Cannot read properties of null (reading 'valid')
at new n (https://editor.gdevelop.io/static/js/8765.a0edf63a.chunk.js:2:1946700)
at n.value (https://editor.gdevelop.io/static/js/5496.45f6639a.chunk.js:1:1963341)
at new n (https://editor.gdevelop.io/static/js/5496.45f6639a.chunk.js:1:1962325)
at Object.createNewInstanceRenderer (https://editor.gdevelop.io/static/js/5496.45f6639a.chunk.js:1:1985233)
at https://editor.gdevelop.io/static/js/5496.45f6639a.chunk.js:1:1980574
at mapReverseFor (https://editor.gdevelop.io/static/js/5496.45f6639a.chunk.js:1:2350186)
...

Additional component context

in n
in t
in Unknown
in div
in div
in Unknown
in Measure
in Nk
in $k
in div
in div
in t
in div
in t
in n
in ForwardRef
in div
in l
in n
in n
in t
in Unknown
in PI
in div
in n
in Ga
in div
in _L
in Unknown
in mt
in f
in u
in v
in m
in j
in h
in h
in Z
in d
in X
in n
in t
in Re
in n
in ut
in vt
in t
in Unknown
in Unknown
in v
in It
in t
in r
in n
in u
in l
in n
in Dr...
@ClementPasteau
Copy link
Collaborator

Tracking this issue, it looks like it is coming from this line of PixiJS library (on the commit of 7.3.0, the version we're using)

https://github.com/pixijs/pixijs/blob/10e3bea3357c04855ef0211f30de4fcc82abbb6f/packages/core/src/textures/Texture.ts#L223

A Texture is being created, but the baseTexture is null.

The trace says this is coming from a PanelSprite: https://github.com/4ian/GDevelop/blob/master/newIDE/app/src/ObjectsRendering/Renderers/RenderedPanelSpriteInstance.js#L101

So it means that the PixiResourcesLoader is not able to load the Texture right away https://github.com/4ian/GDevelop/blob/master/newIDE/app/src/ObjectsRendering/Renderers/RenderedPanelSpriteInstance.js#L89-L91

Not sure how this can happen, a texture is properly created by without a baseTexture?

@ClementPasteau
Copy link
Collaborator

ClementPasteau commented Nov 13, 2023

I'm wondering if those changes to the getPixiTexture() could be the reason 967033c#diff-8aa3ba6d7875a6046f13fd522a758e611022d74ad44af14b7c503b5d489fdf63

@ClementPasteau
Copy link
Collaborator

Possible related issue => pixijs/pixijs#9481

We may be manipulating a texture that's been destroyed, but cannot find how this is happening.

@ClementPasteau ClementPasteau changed the title Crash while using an editor Editor crash - Manipulating a Pixi object after it being destroyed (reading 'valid') Nov 29, 2023
@ClementPasteau ClementPasteau added the 💥crash Bug that is crashing the software label Nov 30, 2023
@4ian 4ian closed this as completed in #6926 Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥crash Bug that is crashing the software
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants