Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Error handling at explore page #96

Open
4 of 5 tasks
IkkiOcean opened this issue Oct 20, 2024 · 7 comments · May be fixed by #120
Open
4 of 5 tasks

[Bug]: Error handling at explore page #96

IkkiOcean opened this issue Oct 20, 2024 · 7 comments · May be fixed by #120

Comments

@IkkiOcean
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

When navigating to the explore page, if the user's wallet is not found, the application continues to load indefinitely without showing an error message. There is no proper error handling in place, which leads to a poor user experience as users are left waiting without any feedback.

Current Behavior:

  • If the application fails to detect or connect a wallet on the explore page, it continues loading indefinitely.
  • There is no feedback or error message displayed to the user.
  • No error handling mechanism is in place to stop the loading process and notify the user of the wallet issue.

Expected Behavior:

  • If the wallet is not found, an appropriate error message should be displayed.
  • The loading spinner should stop, and the user should be notified of the issue.
  • Error handling should be implemented to manage cases where the wallet is not detected or fails to connect.

Steps to Reproduce:

  1. Navigate to the explore page without a connected wallet or with an unsupported wallet.
  2. Observe the loading spinner continuing indefinitely without any error message.

Proposed Solution:

  1. Implement error handling for the "Wallet Not Found" case.
    • If the wallet is not detected, display a clear error message like: Wallet not found. Please connect a valid wallet to explore items.
  2. Stop the loading spinner when the error occurs to avoid infinite loading.
  3. Ensure proper fallback behavior so the user can try reconnecting or return to a previous state.

Add ScreenShots

Screenshot 2024-10-20 at 2 10 52 PM

What browsers are you seeing the problem on?

Safari

Record

  • I agree to follow this project's Code of Conduct
  • I'm a WOB contributor
  • I want to work on this issue
  • I'm willing to provide further clarification or assistance if needed.
@IkkiOcean
Copy link
Contributor Author

Assign me under GSSOC-ext please

Copy link

You've successfully raised your issue, We'll get back to you soon. Don't forget to star⭐ the Repo.

@4darsh-Dev
Copy link
Owner

assigned to you @IkkiOcean,
We've updated our project setup recent
visit : https://decentrade.vercel.app/

Try creating a nft to check the feature

@IkkiOcean
Copy link
Contributor Author

IkkiOcean commented Oct 20, 2024

assigned to you @IkkiOcean, We've updated our project setup recent visit : https://decentrade.vercel.app/

Try creating a nft to check the feature

I tried creating nft but the create button didnt work..

@IkkiOcean
Copy link
Contributor Author

IkkiOcean commented Oct 20, 2024

@4darsh-Dev while working on explore page, I also notice that similar errors are also present on create NFT page so I will be handling them also. We need to implement a check for where the user has connected their wallet to not.

Screenshot 2024-10-20 at 10 45 57 PM

Do you like the error message or you want something else?

@4darsh-Dev
Copy link
Owner

@IkkiOcean
you need to use metmask or any web3 wallet for adding nfts
-- currently we're using Ethereum sepolia test net
-- you can use this feature after adding faucets from chainlink

@IkkiOcean
Copy link
Contributor Author

@4darsh-Dev okay. well I dont have much experience in web3 but I did added the error handling in the explore page so do look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants