Merged in dspace-cris-2023_02_x-DSC-1489 (pull request DSpace#1259)

Hide wide alert banner when no message is provided

Author: atarix83

src/app/system-wide-alert/alert-banner/system-wide-alert-banner.component.html

@@ -1,4 +1,4 @@
-<div *ngIf="(systemWideAlert$ |async)?.active">
+<div *ngIf="(systemWideAlert$ |async)?.active && (systemWideAlert$ |async)?.message">
     <div class="rounded-0 alert alert-warning w100">
         <div class="container">
             <span class="font-weight-bold">

src/app/system-wide-alert/alert-banner/system-wide-alert-banner.component.spec.ts

@@ -19,6 +19,9 @@ describe('SystemWideAlertBannerComponent', () => {
   let systemWideAlertDataService: SystemWideAlertDataService;
 
   let systemWideAlert: SystemWideAlert;
+  let systemWideAlertEmptyMessage: SystemWideAlert;
+  let systemWideAlertNullMessage: SystemWideAlert;
+  let systemWideAlertUndefinedMessage: SystemWideAlert;
   let scheduler: TestScheduler;
 
   beforeEach(waitForAsync(() => {
@@ -36,6 +39,24 @@ describe('SystemWideAlertBannerComponent', () => {
       countdownTo: utcToZonedTime(countDownDate, 'UTC').toISOString()
     });
 
+    systemWideAlertEmptyMessage = Object.assign(new SystemWideAlert(), {
+      alertId: 1,
+      message: '',
+      active: true
+    });
+
+    systemWideAlertNullMessage = Object.assign(new SystemWideAlert(), {
+      alertId: 1,
+      message: null,
+      active: true
+    });
+
+    systemWideAlertUndefinedMessage = Object.assign(new SystemWideAlert(), {
+      alertId: 1,
+      message: undefined,
+      active: true
+    });
+
     systemWideAlertDataService = jasmine.createSpyObj('systemWideAlertDataService', {
       searchBy: createSuccessfulRemoteDataObject$(createPaginatedList([systemWideAlert])),
     });
@@ -110,5 +131,29 @@ describe('SystemWideAlertBannerComponent', () => {
       const banner = fixture.debugElement.queryAll(By.css('span'));
       expect(banner.length).toEqual(0);
     });
+
+    it('should not display an alert when no message is present', () => {
+      comp.systemWideAlert$.next(systemWideAlertEmptyMessage);
+      fixture.detectChanges();
+
+      const banner = fixture.debugElement.queryAll(By.css('span'));
+      expect(banner.length).toEqual(0);
+    });
+
+    it('should not display an alert when null message is present', () => {
+      comp.systemWideAlert$.next(systemWideAlertNullMessage);
+      fixture.detectChanges();
+
+      const banner = fixture.debugElement.queryAll(By.css('span'));
+      expect(banner.length).toEqual(0);
+    });
+
+    it('should not display an alert when undefined message is present', () => {
+      comp.systemWideAlert$.next(systemWideAlertUndefinedMessage);
+      fixture.detectChanges();
+
+      const banner = fixture.debugElement.queryAll(By.css('span'));
+      expect(banner.length).toEqual(0);
+    });
   });
 });