Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer-to-peer code review #6

Open
Behnam1369 opened this issue Mar 1, 2022 · 0 comments
Open

Peer-to-peer code review #6

Behnam1369 opened this issue Mar 1, 2022 · 0 comments

Comments

@Behnam1369
Copy link

Behnam1369 commented Mar 1, 2022

Hi @41hulk

Congratulations! You did a good job.

To highlight:

  • Your code is DRY. ✔️
  • Your code is free of linter errors. ✔️
  • You have implemented ES6 features to make your code more readable. ✔️

And of course, there are a few things that you can improve

  • Delete button is not removing the task.
  • Your link to the live demo is redirecting users to the README file instead of redirecting to the index.html page.
  • The result of your work is not built into the dist folder.
  • You can split your code into more modules.

Cheers and Happy Coding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant