Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer to Peer review #5

Open
2 tasks
JuanLPalacios opened this issue Feb 24, 2022 · 1 comment
Open
2 tasks

Peer to Peer review #5

JuanLPalacios opened this issue Feb 24, 2022 · 1 comment

Comments

@JuanLPalacios
Copy link

JuanLPalacios commented Feb 24, 2022

Your code seems great so far! 👏
but here is a couple of optional things you could improve on🧐

  • refactor a little the names and separate the functions for DOM manipulation and pure funtions.
  • add a blur event listener on the text input to make it look even more professional
@Kakalanp
Copy link

Your project looks great! @41hulk 🎉

I fully agree with @JuanLPalacios's review, but I'd like to add 🔍:

  • Try to fix your live version, as it is showing the README.md file at the moment. 😮
    image

Fixing this issue shouldn't represent a challenge, and it will improve navigation of your project by a lot. ✨

Good luck with the changes/implementations 🍀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants