Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strategy / matrix / include should be processed #5

Open
tribbloid opened this issue Nov 16, 2021 · 4 comments
Open

Strategy / matrix / include should be processed #5

tribbloid opened this issue Nov 16, 2021 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@tribbloid
Copy link

The following 2 strategy matrix are identical:

      matrix:
        scalaVersion: ["2.13.6", "2.13.7"]

equals

      matrix:
        include:
          - scalaVersion: "2.13.6"
          - scalaVersion: "2.13.7"

But only the first one can be parse successfully and generate the proper badge

The second produces multiple jobs in github actions, but as a badge they cannot be identified:

badge-errors

Is this a known limitation?

@svetlyak40wt
Copy link
Member

The case with "include" is not supported just because I didn't have it in mind :(

@svetlyak40wt
Copy link
Member

Are there any cases when you really want to use second variant with include list instead of the first version?

@tribbloid
Copy link
Author

Thanks a lot! In my case I sometimes want to construct an incomplete matrix, e.g.:

      matrix:
        include:
          - scalaVersion: "2.13.6"
            experimental: true
          - scalaVersion: "2.13.7"
            experimental: true

The argument ${{experimental}} can then affect some workflow behaviour

@svetlyak40wt
Copy link
Member

Then these include should be supported in the app. However, I don't have time for this right now :(

@svetlyak40wt svetlyak40wt changed the title strategy / matrix / include are ignored Strategy / matrix / include should be processed Nov 17, 2021
@svetlyak40wt svetlyak40wt added enhancement New feature or request help wanted Extra attention is needed labels Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants