Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate flash.sh script into image #80

Open
4 tasks
macpijan opened this issue Nov 4, 2024 · 4 comments · May be fixed by #83
Open
4 tasks

Integrate flash.sh script into image #80

macpijan opened this issue Nov 4, 2024 · 4 comments · May be fixed by #83
Assignees
@DaniilKl

Comments

@macpijan
Copy link
Member

macpijan commented Nov 4, 2024 •
edited by EduKav1813
Loading

Integrate script from: 3mdeb/RteCtrl#22 into v0.8.X release

  • Add recipe for flash.sh script to meta-rte and integrate it into image by default
  • Remove this script from RteCtrl
  • Scan Dasharo documentation references to flash.sh and remove them. Or leave a note that this flash.sh script is integrated on RTE OS v0.8.x or higher if needed, depending on the found case.
  • Extend script with additional parameters/env variables, such as:
    • ability to select 1.8V vs 3.3V (currently it is hardcoded to 3.3V)
    • ability to provide some extra parameters to flashrom command (such as: -ifd -i fd -i me -i bios)
@macpijan
Copy link
Member Author

macpijan commented Nov 5, 2024 •
edited
Loading

This is designed to have some working solution in a short term.

As suggested in 3mdeb/RteCtrl#22 (comment) already, this flash.sh script is not a perfect approach, and we already have something better with osfv_cli.

This can take a bit more time to discuss and implement, that is why we have a separate ticket for it here: #82

@artur-rs artur-rs assigned DaniilKl and unassigned artur-rs and EduKav1813 Nov 7, 2024
DaniilKl added a commit that referenced this issue Nov 7, 2024
@DaniilKl
recipes-go: 3mdeb-rtectrl: flash.sh: add
52c9645 
Add flash.sh script from 3mdeb/RteCtrl#22.
For more inf. check #80.

Signed-off-by: Daniil Klimuk <[email protected]>
@DaniilKl DaniilKl linked a pull request Nov 7, 2024 that will close this issue
Open
DaniilKl added a commit to Dasharo/docs that referenced this issue Nov 7, 2024
@DaniilKl
docs: add flash.sh script note
7687926 
For more inf. check 3mdeb/meta-rte#80.

Signed-off-by: Daniil Klimuk <[email protected]>
@DaniilKl DaniilKl mentioned this issue Nov 7, 2024
Merged
@DaniilKl DaniilKl linked a pull request Nov 7, 2024 that will close this issue
Integrate flash.sh from RteCtrl #83
Open
@DaniilKl DaniilKl mentioned this issue Nov 7, 2024
Merged
@macpijan
Copy link
Member Author

macpijan commented Nov 7, 2024

@wessel-novacustom

If you'd like to test the updated version of the script from: https://github.com/3mdeb/meta-rte/pull/83/files

The file can be downloaded here: https://raw.githubusercontent.com/3mdeb/meta-rte/c4c0f2b6c947061defa1b83bd585745ec0ecadb6/recipes-go/3mdeb-rtectrl/3mdeb-rtectrl/flash.sh

DaniilKl added a commit to Dasharo/docs that referenced this issue Nov 8, 2024
@DaniilKl
docs: add flash.sh script note
c72463f 
For more inf. check 3mdeb/meta-rte#80.

Signed-off-by: Daniil Klimuk <[email protected]>
@macpijan
Copy link
Member Author

@wessel-novacustom did you have a chance to test this?

@wessel-novacustom
Copy link

@wessel-novacustom did you have a chance to test this?

Not yet, I will do so on Saturday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DaniilKl DaniilKl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Integrate flash.sh from RteCtrl 3mdeb/meta-rte
5 participants
@macpijan @artur-rs @wessel-novacustom @DaniilKl @EduKav1813