-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remux auto adjust does not match max headroom value #229
Comments
This was tested on 0.6.2 Beta 2 |
The same code is used in each case to generate the value so it is hard to see how this can happen. I can't reproduce this myself so I need the project file for this and ideally the track you are analysing/remuxing. This will be easier to share if you reduce it to a sample of a minute or so. |
one thing to bear in mind is that it currently ignores the channel mapping and just works off the signals defined in the app this may well be related as you have a set of channel mappings listed to Default which usually means you have no signal loaded, it should just stick at 0 in this case when you click the button though |
I think I know why you cant reproduce. Based on some of the posts I misunderstood that you could do the remux without having the audio extracted first. I assume based on what you send above the signals still need to be created. I tested it that way and the functionality is correct. So now I just dont have to add an additional gain in the filter. Sorry for the confusion. One question though I know I read some posts back and forth with Aron and yourself and I think you seemed to feel that to cover off the headroom the additional gain decrease should be more than 1 db over the clipping level. Does the remux do this? For example if the max clipping value is -12.5 I would have added a -14 DB gain filter, so the headroom would be more than 1. Is this what the feature is going to do or is it going to simply add a -12.5 gain? Thx and again sorry for the mixup |
Thanks for investigating further. It just does the value calculated with no additional headroom atm. I think the technically correct way to do this would be to do something like a 4x oversample and then filter, could be a bit slow though and very memory intensive. I guess a quick version would be to just do that to a snippet a few minutes around the peaks though. |
No problem glad to help sorry again for the mixup. That would be a cool nice to have 👍 |
Using the auto-remux does not seem to match with the headroom values shown
In my test the auto adjust was adjusting the remux by -5.11 DB
After analyzing the extracted audio with the Filter applied the largest noted clipping using the headroom value was -12.72 DB
As per Arons instructions in the RemuxBEQ below the expected remux auto adjust should be more than -12.72DB adjusted
The text was updated successfully, but these errors were encountered: