Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git pull does not delete files #221

Open
bmiller opened this issue Mar 2, 2019 · 6 comments
Open

Git pull does not delete files #221

bmiller opened this issue Mar 2, 2019 · 6 comments
Labels
bug Something isn't working

Comments

@bmiller
Copy link
Contributor

bmiller commented Mar 2, 2019

The git pull operation for the beq files repo does not delete files when one is renamed. A couple recent examples are John Wick 2, Underworld Blood Wars, or Ralph Breaks the Internet. The files for all three were renamed during updates.

It looks like this is an issue with porcelain's pull function from the research I've done so far. I wanted to get it documented as a known issue here. I'm looking for a solution to it since it's affecting the browser app too.

@3ll3d00d 3ll3d00d added the bug Something isn't working label Mar 3, 2019
@3ll3d00d
Copy link
Owner

3ll3d00d commented Mar 3, 2019

looks like jelmer/dulwich#452

@bmiller
Copy link
Contributor Author

bmiller commented Mar 3, 2019

Yeah, I saw that bug the other night when I was looking into it. I forgot to reference it. It's what lead me to believe that it's a porcelain issue and not BEQDesigner's use of it.

@3ll3d00d
Copy link
Owner

3ll3d00d commented Mar 3, 2019

jelmer/dulwich#588 has a possible workaround for something that looks a bit more like a working git reset --hard

@JanSam
Copy link

JanSam commented Oct 27, 2019

As discussed in the avs thread lately, a button to purge the BEQ files(under preferences) would be great too, not just for the merge portion of the BEQd.

@bmiller
Copy link
Contributor Author

bmiller commented Oct 19, 2020

@3ll3d00d have you looked into pygit2 before? It uses libgit2 under the hood which complicates things a little for building. I was going to use it with a Swift library for the iOS app I'm working on and thought of checking on it for BEQd. I could port my iOS stuff to python after I do it if there wasn't going to be issues doing so.

@3ll3d00d
Copy link
Owner

a quick search suggests it has it's own problems as well as bringing packaging complexity inc the need to build from source on MacOS (e.g. iterative/dvc#2215),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants