Cannot specify --all-warnings-as-errors with no status codes

[phillipuniverse]

I would like to turn every warning the linter emits into an error.

From the docs:

Optionally specify migration test codes to handle as errors. When no test code specified, all warnings are handled as errors.

But the implementation does not work when checking the 'when no test code specified' part. The problem is in this code, either this doesn't work or I don't know how to appropriately specify an empty list for this option on the command line:

django-migration-linter/django_migration_linter/management/utils.py

Lines 55 to 67 in 117967a

	def extract_warnings_as_errors_option(
	warnings_as_errors: list[str] | None,
	) -> tuple[list[str] | None, bool]:
	if isinstance(warnings_as_errors, list):
	warnings_as_errors_tests = warnings_as_errors
	# If the option is specified but without any test codes,
	# all warnings become errors
	all_warnings_as_errors = len(warnings_as_errors) == 0
	else:
	warnings_as_errors_tests = None
	all_warnings_as_errors = False
	return warnings_as_errors_tests, all_warnings_as_errors

Here are some examples and what happens in the debugger:

python manage.py lintmigrations --no-cache --warnings-as-error CREATE_INDEX CREATE_INDEX_EXCLUSIVE DROP_INDEX REINDEX

python manage.py lintmigrations --no-cache --warnings-as-error

python manage.py lintmigrations --no-cache --warnings-as-error= (same result as python manage.py lintmigrations --no-cache --warnings-as-error '')

So what's the right way to get the behavior of treating all warnings as errors without passing them all individually?

[lieryan]

This works for me:

./manage.py lintmigrations --git-commit-id ... --no-cache --warnings-as-errors

Also, specifying this in pyproject.toml, like so:

[tool.django_migration_linter]
warnings_as_errors = []

I think the documentations can be improved since it's rather unclear how to specify multiple warning names in the CLI and for each of the config file formats. Having some examples would be nice.

[johnnymetz]

I think improving the documentation would be great here. I set warnings_as_errors = True and was confused when it wasn't working.