-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Support] nbgitpuller link breaks after update - University of Toronto #3603
Comments
nbgitpuller works with https://r.datatools.utoronto.ca/ if the repo is public. However the repo in the ticket is private and it was reported that it worked on Monday, I believe before the migration? |
I am confused of the fact that I don't see evidence that private GitHub pulling was setup for the toronto hub https://infrastructure.2i2c.org/howto/features/private-nbgitpuller/#allow-nbgitpuller-to-pull-from-private-github-repos |
Ahh, the GitHub app is not under the 2i2c org, but in https://github.com/organizations/utoronto-2i2c/settings/apps/ and this is why I couldn't find it.
infrastructure/config/clusters/utoronto/common.values.yaml Lines 59 to 65 in b6846fb
|
2i2c-org/utoronto-r-image#17 should make it available |
Opened #3604 to move the setup of the https://github.com/organizations/utoronto-2i2c/settings/apps/utoronto-jupyterhub-private-cloner app under the default hub, as I believe we need a new one for the R hub |
Hmm, the weird thing is that using nbgitpuller with a private repo on https://jupyter.utoronto.ca doesn't work either, although it seems to have everything setup 🤔 |
I've opened #3605 that registeres the new GitHub app created to be used for pulling by the r hub https://github.com/organizations/utoronto-2i2c/settings/apps/utoronto-r-hub-private-cloner |
I believe what remains now is to merge the PRs below:
and then update the r hub user image with a tag that has 2i2c-org/utoronto-r-image#17 |
I merged #3604 and then reverted #3606 - it turns out 2i2c-org/utoronto-r-image#17 was actually the only change needed! It does mean that the same GitHub app is used for both jupyter.utoronto.ca and r.datatools.utoronto.ca, but that's actually ok as it makes the migration from jupyter.utoronto.ca to r.datatools.utoronto.ca easier - people will not have to reinstall. |
I opened #3608 to document. @GeorgianaElena do you think it's ok to delete the github app created for the R hub? We should probably try to bring the github app for the jupyter app to this org! But idk if that means everyone will have to reinstall the app? |
Thank you @yuvipanda for sorting this out! I've deleted the new app and will close this issue as it's now resolved 🚀 |
The Freshdesk ticket link
https://2i2c.freshdesk.com/a/tickets/1229
Ticket request type
Something is not working
Ticket impact
🟥 Critical
Short ticket description
Nbgitpuller links not working.
When the hub is:
(Optional) Investigation results
No investigation happened yet as I wanted to first open the issue for visibility.
The text was updated successfully, but these errors were encountered: