From a83abac916267a8965c505af11e962c21ab3ddef Mon Sep 17 00:00:00 2001
From: doyeoo <ehdusla013@gmail.com>
Date: Sun, 26 Nov 2023 14:50:09 +0900
Subject: [PATCH] =?UTF-8?q?[refactor]=20=EC=83=9D=EC=84=B1=EC=9E=90=20?=
 =?UTF-8?q?=EB=A9=94=EC=86=8C=EB=93=9C=20=EB=B3=80=EA=B2=BD?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../mission/dto/response/MissionsResponseDTO.java  | 12 ++++++++++--
 .../domain/mission/service/MissionService.java     |  2 +-
 .../dto/response/SubPlacesResponseDTO.java         | 14 ++++++++++++--
 .../domain/subPlace/service/SubPlaceService.java   |  4 ++--
 4 files changed, 25 insertions(+), 7 deletions(-)

diff --git a/src/main/java/sungdong29/backend/domain/mission/dto/response/MissionsResponseDTO.java b/src/main/java/sungdong29/backend/domain/mission/dto/response/MissionsResponseDTO.java
index cc78495..873699a 100644
--- a/src/main/java/sungdong29/backend/domain/mission/dto/response/MissionsResponseDTO.java
+++ b/src/main/java/sungdong29/backend/domain/mission/dto/response/MissionsResponseDTO.java
@@ -1,6 +1,6 @@
 package sungdong29.backend.domain.mission.dto.response;
 
-import lombok.AllArgsConstructor;
+import lombok.Builder;
 import lombok.Getter;
 import lombok.Setter;
 
@@ -8,7 +8,15 @@
 
 @Getter
 @Setter
-@AllArgsConstructor
 public class MissionsResponseDTO {
     List<MissionResponseDTO> missions;
+
+    @Builder
+    private MissionsResponseDTO(List<MissionResponseDTO> missions) { this.missions=missions; };
+
+    public static MissionsResponseDTO from(List<MissionResponseDTO> missions) {
+        return MissionsResponseDTO.builder()
+                .missions(missions)
+                .build();
+    }
 }
diff --git a/src/main/java/sungdong29/backend/domain/mission/service/MissionService.java b/src/main/java/sungdong29/backend/domain/mission/service/MissionService.java
index 6f79b99..b7e41da 100644
--- a/src/main/java/sungdong29/backend/domain/mission/service/MissionService.java
+++ b/src/main/java/sungdong29/backend/domain/mission/service/MissionService.java
@@ -34,7 +34,7 @@ public MissionsResponseDTO findMissionsBySubPlaceId(Long subPlaceId) {
                 .stream()
                 .map(mission -> mapper.map(mission, MissionResponseDTO.class))
                 .collect(Collectors.toList());
-        return new MissionsResponseDTO(missionResponseDTOS);
+        return MissionsResponseDTO.from(missionResponseDTOS);
     }
 
     public void accomplishMission(UserDetails userDetails, Long missionId) {
diff --git a/src/main/java/sungdong29/backend/domain/subPlace/dto/response/SubPlacesResponseDTO.java b/src/main/java/sungdong29/backend/domain/subPlace/dto/response/SubPlacesResponseDTO.java
index b17f753..69f4007 100644
--- a/src/main/java/sungdong29/backend/domain/subPlace/dto/response/SubPlacesResponseDTO.java
+++ b/src/main/java/sungdong29/backend/domain/subPlace/dto/response/SubPlacesResponseDTO.java
@@ -1,6 +1,6 @@
 package sungdong29.backend.domain.subPlace.dto.response;
 
-import lombok.AllArgsConstructor;
+import lombok.Builder;
 import lombok.Getter;
 import lombok.Setter;
 
@@ -8,7 +8,17 @@
 
 @Getter
 @Setter
-@AllArgsConstructor
 public class SubPlacesResponseDTO {
     List<SubPlaceResponseDTO> subPlaces;
+
+    @Builder
+    private SubPlacesResponseDTO(List<SubPlaceResponseDTO> subPlaces) {
+        this.subPlaces = subPlaces;
+    }
+
+    public static SubPlacesResponseDTO from(List<SubPlaceResponseDTO> subPlaces) {
+        return SubPlacesResponseDTO.builder()
+                .subPlaces(subPlaces)
+                .build();
+    }
 }
diff --git a/src/main/java/sungdong29/backend/domain/subPlace/service/SubPlaceService.java b/src/main/java/sungdong29/backend/domain/subPlace/service/SubPlaceService.java
index cf77e0c..57bb66a 100644
--- a/src/main/java/sungdong29/backend/domain/subPlace/service/SubPlaceService.java
+++ b/src/main/java/sungdong29/backend/domain/subPlace/service/SubPlaceService.java
@@ -13,7 +13,7 @@
 
 @Service
 @RequiredArgsConstructor
-public class SubPlaceService {
+public class  SubPlaceService {
 
     private final SubPlaceRepository subPlaceRepository;
     private final ModelMapper mapper;
@@ -24,6 +24,6 @@ public SubPlacesResponseDTO findSubPlaces(Long placeId) {
                 .stream()
                 .map(subPlace -> mapper.map(subPlace, SubPlaceResponseDTO.class))
                 .collect(Collectors.toList());
-        return new SubPlacesResponseDTO(subPlaceResponseDTOS);
+        return SubPlacesResponseDTO.from(subPlaceResponseDTOS);
     }
 }