Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percent decoding of file names takes place even if the filename doesn't come from the URL #899

Open
friskgit opened this issue Oct 17, 2022 · 8 comments
Labels
bug Something isn't working

Comments

@friskgit
Copy link

Hi,

Love to try organize! I tried to connect to Dropbox (Android) but it failed. Now I just get a blank screen when I try to reconnect and a pop-up that says connection failed.

Any hints?

Thanks, Henrik

@schoettl
Copy link
Collaborator

Hi,

What does the pop-up exactly say? I darkly remember similar symptoms. We can look up the exact error message in the closed issues here.

Did you try also on a desktop PC? Does it work there?

@munen
Copy link
Collaborator

munen commented Oct 17, 2022

Hi there

thank you for the report. A console log output would be very helpful. Generally speaking, logging in to Dropbox works. I just tried it, again: https://www.dropbox.com/s/g55m70qmbpqp2zb/Video%2017.10.22%2C%2009%2027%2041.mp4?dl=0

Kind regards

@munen munen added the question Further information is requested label Oct 17, 2022
@friskgit
Copy link
Author

Hi,

Yes, the log in seems to have worked. I got a message from Dropbox that organice was authorized.

The popup says:

organice.200ok.ch says
There was an error retrieving your files!

I can get to a page that says "You don't have any file settings - add one by pressing the + button", but there is no + button.

I haven't done any developing for android, but if you tell me how to get the log I'd be happy to do submit it!

@friskgit
Copy link
Author

Tried on my laptop, but it gives the same result. Is there a special place where the org files have to be on the Dropbox?

@schoettl
Copy link
Collaborator

In the desktop PC browser, press F12 (or menu -> dev tools); then, the error log should show up. It should look similar like in the screenshots of this issue: #848

@friskgit
Copy link
Author

Hi,

It appears to have to do with a percent sign in one of the directories in my Dropbox:

Pathname "/files/Katt Hernandez 50% Seminar" could not be decoded. This is likely caused by an invalid percent-encoding.

Is it possible to connect organice to the specific directory that contains the org files rather than the entire structure? I can probably get rid of this directory though.

@friskgit
Copy link
Author

After removing that directory it works. For some reason I still can't see all of the .org files in the file settings dialog though. I see some, and if I open a sub directory within my org files directory, I can see the org files there. The log does not show anything

@schoettl
Copy link
Collaborator

Regarding this original issue, I can confirm the bug. (mkdir ~/Dropbox/'test%')

I get this error even if I didn't try to show test%s content or a file in it. Maybe the percent decoding is done in the wrong place. It should be done only right after grabbing the file path from the URL.

URIError: Pathname "/files/test%" could not be decoded. This is likely caused by an invalid percent-encoding.
    g history.js:87
    h locationUtils.js:8
    m Link.js:93
    React 6
    Redux 4
    Ko toggle_color_scheme.js:20
    Go live_sync.js:19
    Redux 2
    hs sync_backend.js:73
sync_backend.js:84:16

Regarding the questions unrelated to this issue, see #304 and maybe #896.

@schoettl schoettl added bug Something isn't working and removed question Further information is requested labels Oct 19, 2022
@schoettl schoettl changed the title Can't connect to Dropbox Percent decoding of file names takes place even if the filename doesn't come from the URL Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants