fix(engine): Exit(1) when compiler fails to alert dev

Author: Pazaz

README.md

@@ -17,26 +17,17 @@ It won't ever profit off your trademarks. Without this project, this version of
 
 *To players*: So happy to have you interested! RuneScape 2 launched on March 29, 2004. We have no copies of that revision, but we do have some client caches from May 2004. This project emulates *May 18, 2004*, which was live until June 1 of that year. It has Treasure Trails and Big Chompy Bird Hunting. The next revision after this added Elemental Workshop I.
 
-## Environment Dependencies
-
-- [NodeJS 20+](https://nodejs.org/) (current LTS) or [18](https://nodejs.org/download/release/v18.18.2/) (last LTS)
-- [Java 17+](https://adoptium.net/)
-- If you're using VS Code (recommended), [we have an extension to install here.](https://marketplace.visualstudio.com/items?itemName=2004scape.runescriptlanguage)
-
-Java is required for RuneScriptCompiler.jar, our content language compiler.
-
-You can download RuneScriptCompiler from the [#dev-resources](https://discord.com/channels/953326730632904844/1125601647574396978) Discord channel. Place the jar file in the root directory of the project.  
-
-RuneScriptCompiler is not yet open-source, sorry for any inconvenience.
-
 ## Getting Started
 
-1. Clone the repo
-2. Install [environment dependencies](#environment-dependencies)
-3. Run `npm ci` to install code dependencies
-4. Copy the file `.env.example` to `.env`
-5. Run `npm run build` to create the client and server cache. This may take a few minutes the first time
-6. Run `npm start` to start the server
+1. Download this repo to your computer
+2. Install our list of [dependencies](#environment-dependencies)
+3. Create a `.env` file by copying the file `.env.example` to be called `.env`
+4. Open the folder you downloaded in a command prompt
+5. Run `npm ci`, this installs necessary packages
+6. Run `npm run build`, this creates the client and server cache the first time
+7. Run `npm start`
+
+Now open [http://localhost](http://localhost) in your browser and play!
 
 ### Using the setup script
 
@@ -62,6 +53,18 @@ Once the container starts, it automatically starts running `setup.sh`. You can c
 
 Another option for building your Dev Container is to instead clone your repository onto your local machine first and then run `Dev Containers: Open Folder in Container` and work that way by mounting the local files into your container. This way, you can have RuneScriptCompiler.jar in your workspace from the get-go. **Note: The npm scripts are much slower when the container is running this way.**
 
+## Environment Dependencies
+
+- [NodeJS 20+](https://nodejs.org/) (current LTS) or [18](https://nodejs.org/download/release/v18.18.2/) (last LTS)
+- [Java 17+](https://adoptium.net/)
+- If you're using VS Code (recommended), [we have an extension to install here.](https://marketplace.visualstudio.com/items?itemName=2004scape.runescriptlanguage)
+
+Java is required for RuneScriptCompiler.jar, our content language compiler.
+
+You can download RuneScriptCompiler from the [#dev-resources](https://discord.com/channels/953326730632904844/1125601647574396978) Discord channel. Place the jar file in the root directory of the project.  
+
+RuneScriptCompiler is not yet open-source, sorry for any inconvenience.
+
 ## Development Workflow
 
 Content developers (likely you!) can run `npm start` to start the server. This will watch for changes to the config and script files as well as automatically rebuild them.

src/lostcity/tools/pack/server.ts

@@ -25,7 +25,7 @@ async function packServer() {
     try {
         child_process.execSync(`"${Environment.JAVA_PATH}" -jar RuneScriptCompiler.jar`, { stdio: 'inherit' });
     } catch (err) {
-        // ignore
+        process.exit(1);
     }
     console.timeEnd('packing server...');
 }