feat(engine): Updated unpack process to use different dir

Also optimized pdata/gdata in Packet
And removed the old dump folder cleanup, which existed for when bz2 would dump temp files there
There's a few more controls exposed in .env now

Author: Pazaz

.env.example

@@ -23,6 +23,9 @@ GAME_PORT=43594
 
 # SKIP_CRC=false
 # JAVA_PATH="C:\Program Files\Eclipse Adoptium\jdk-17.0.11.9-hotspot\bin\java"
+# DATA_SRC_DIR=data/src
+# VALIDATE_PACK=true
+# STRICT_FOLDERS=true
 
 # JMODS=player1,player2,player3
 

src/jagex2/io/FileStream.ts

@@ -189,7 +189,7 @@ export default class FileStream {
                 available = 512;
             }
 
-            this.dat.pdata(data.slice(written, written + available));
+            this.dat.pdata(data.subarray(written, written + available));
             written += available;
             sector = nextSector;
         }

src/jagex2/io/Packet.ts

@@ -224,10 +224,8 @@ export default class Packet extends Hashable {
     }
 
     pdata(src: Uint8Array, offset: number, length: number): void {
-        const total: number = offset + length;
-        for (let i: number = offset; i < total; i++) {
-            this.#view.setUint8(this.pos++, src[i]);
-        }
+        this.data.set(src.subarray(offset, offset + length), this.pos);
+        this.pos += length - offset;
     }
 
     psize4(size: number): void {
@@ -323,10 +321,8 @@ export default class Packet extends Hashable {
     }
 
     gdata(dest: Uint8Array, offset: number, length: number): void {
-        const total: number = offset + length;
-        for (let i: number = offset; i < total; i++) {
-            dest[i] = this.#view.getUint8(this.pos++);
-        }
+        dest.set(this.data.subarray(this.pos, this.pos + length), offset);
+        this.pos += length;
     }
 
     gsmarts(): number {

src/lostcity/app.ts

@@ -18,11 +18,6 @@ if (!fs.existsSync('.env')) {
 
 fs.mkdirSync('data/players', { recursive: true });
 
-if (fs.existsSync('dump')) {
-    fs.rmSync('dump', { recursive: true, force: true });
-    fs.mkdirSync('dump', { recursive: true });
-}
-
 await World.start();
 
 startWeb();

src/lostcity/login.ts

@@ -16,10 +16,5 @@ if (!fs.existsSync('data/config/login.json')) {
 
 fs.mkdirSync('data/players', { recursive: true });
 
-if (fs.existsSync('dump')) {
-    fs.rmSync('dump', { recursive: true, force: true });
-    fs.mkdirSync('dump', { recursive: true });
-}
-
 const login = new LoginServer();
 login.start();

src/lostcity/tools/pack/symbols.ts

@@ -179,9 +179,7 @@ export function generateServerSymbols() {
     }
     fs.writeFileSync('data/symbols/vars.sym', varsSymbols);
 
-    console.time('Loading param.dat');
     ParamType.load('data/pack');
-    console.timeEnd('Loading param.dat');
 
     let paramSymbols = '';
     const params = loadPack('data/src/pack/param.pack');

src/lostcity/tools/packconfig/PackShared.ts

@@ -50,8 +50,8 @@ export class PackedData {
     marker: number;
 
     constructor(size: number) {
-        this.dat = Packet.alloc(4);
-        this.idx = Packet.alloc(2);
+        this.dat = Packet.alloc(5);
+        this.idx = Packet.alloc(3);
         this.size = size;
 
         this.dat.p2(size);
@@ -194,8 +194,8 @@ export type ConfigDatIdx = { client: PackedData, server: PackedData };
 export type ConfigPackCallback = (configs: Map<string, ConfigLine[]>) => ConfigDatIdx;
 export type ConfigSaveCallback = (dat: Packet, idx: Packet) => void;
 
-export function readConfigs(extension: string, requiredProperties: string[], parse: ConfigParseCallback, pack: ConfigPackCallback, saveClient: ConfigSaveCallback, saveServer: ConfigSaveCallback) {
-    const files = readFiles(findFiles('data/src/scripts', extension));
+export function readConfigs(extension: string, requiredProperties: string[], parse: ConfigParseCallback, pack: ConfigPackCallback, saveClient: ConfigSaveCallback, saveServer: ConfigSaveCallback, srcDir: string = 'data/src/scripts') {
+    const files = readFiles(findFiles(srcDir, extension));
 
     const configs = new Map<string, ConfigLine[]>();
     files.forEach((value, file) => {