1der1
diff --git a/Diff for: ‎.eslintignore
+2 b/Diff for: ‎.eslintignore
+2
diff --git a/Diff for: ‎.eslintrc.js
+1-1 b/Diff for: ‎.eslintrc.js
+1-1
diff --git a/Diff for: ‎lighthouse-cli/test/fixtures/byte-efficiency/bundle.js
+156 b/Diff for: ‎lighthouse-cli/test/fixtures/byte-efficiency/bundle.js
+156
diff --git a/Diff for: ‎lighthouse-cli/test/fixtures/byte-efficiency/bundle.js.map
+13 b/Diff for: ‎lighthouse-cli/test/fixtures/byte-efficiency/bundle.js.map
+13
diff --git a/Diff for: ‎lighthouse-cli/test/fixtures/byte-efficiency/tester.html
+1 b/Diff for: ‎lighthouse-cli/test/fixtures/byte-efficiency/tester.html
+1
diff --git a/Diff for: ‎lighthouse-cli/test/smokehouse/test-definitions/byte-efficiency/byte-config.js
+7 b/Diff for: ‎lighthouse-cli/test/smokehouse/test-definitions/byte-efficiency/byte-config.js
+7
diff --git a/Diff for: ‎lighthouse-cli/test/smokehouse/test-definitions/byte-efficiency/expectations.js
+47-4 b/Diff for: ‎lighthouse-cli/test/smokehouse/test-definitions/byte-efficiency/expectations.js
+47-4
@@ -7,6 +7,8 @@
 **/generated/**
 **/source-maps/**
 
+lighthouse-cli/test/fixtures/byte-efficiency/bundle.js
+
 /dist/**
 
 coverage/**
 
@@ -50,7 +50,7 @@ module.exports = {
     'no-unused-vars': [2, {
       vars: 'all',
       args: 'after-used',
-      argsIgnorePattern: '(^reject$|^_$)',
+      argsIgnorePattern: '(^reject$|^_+$)',
       varsIgnorePattern: '(^_$)',
     }],
     'space-infix-ops': 2,
 
@@ -54,6 +54,7 @@
   }
 </style>
 <script src="script.js" type="application/javascript"></script>
+<script src="bundle.js"></script>
 </head>
 
 <body>
 
@@ -27,6 +27,13 @@ const config = {
     ],
     throttlingMethod: 'devtools',
   },
+  // source-maps is not yet in the default config.
+  passes: [{
+    passName: 'defaultPass',
+    gatherers: [
+      'source-maps',
+    ],
+  }],
 };
 
 module.exports = config;
@@ -29,6 +29,14 @@ const expectations = [
           source: 'head',
           devtoolsNodePath: '2,HTML,0,HEAD,5,SCRIPT',
         },
+        {
+          type: null,
+          src: 'http://localhost:10200/byte-efficiency/bundle.js',
+          async: false,
+          defer: false,
+          source: 'head',
+          devtoolsNodePath: '2,HTML,0,HEAD,6,SCRIPT',
+        },
         {
           type: null,
           src: null,
@@ -106,6 +114,12 @@ const expectations = [
                 wastedBytes: '6559 +/- 100',
                 wastedPercent: 100,
               },
+              {
+                url: 'http://localhost:10200/byte-efficiency/bundle.js',
+                totalBytes: '13000 +/- 1000',
+                wastedBytes: '2350 +/- 100',
+                wastedPercent: '19 +/- 5',
+              },
             ],
           },
         },
@@ -122,9 +136,38 @@ const expectations = [
           details: {
             overallSavingsBytes: '>=25000',
             overallSavingsMs: '>300',
-            items: {
-              length: 2,
-            },
+            items: [
+              {
+                url: 'http://localhost:10200/byte-efficiency/script.js',
+                totalBytes: '53000 +/- 1000',
+                wastedBytes: '22000 +/- 1000',
+              },
+              {
+                url: 'http://localhost:10200/byte-efficiency/tester.html',
+                totalBytes: '15000 +/- 1000',
+                wastedBytes: '6500 +/- 1000',
+              },
+              {
+                url: 'http://localhost:10200/byte-efficiency/bundle.js',
+                totalBytes: 12913,
+                wastedBytes: 5827,
+                sources: [
+                  '…./b.js',
+                  '…./c.js',
+                  '…webpack/bootstrap',
+                ],
+                sourceBytes: [
+                  4417,
+                  2200,
+                  2809,
+                ],
+                sourceWastedBytes: [
+                  2191,
+                  2182,
+                  1259,
+                ],
+              },
+            ],
           },
         },
         'offscreen-images': {
@@ -156,7 +199,7 @@ const expectations = [
             overallSavingsMs: '>700',
             overallSavingsBytes: '>50000',
             items: {
-              length: 2,
+              length: 3,
             },
           },
         },
Original file line number	Diff line number	Diff line change
`@@ -54,6 +54,7 @@`
`54`	`54`	`}`
`55`	`55`	`</style>`
`56`	`56`	`<script src="script.js" type="application/javascript"></script>`
	`57`	`+<script src="bundle.js"></script>`
`57`	`58`	`</head>`
`58`	`59`
`59`	`60`	`<body>`