Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow exported type file to have code that won't be overwritten #111

Open
praveenperera opened this issue Apr 26, 2023 · 1 comment
Open
Labels
feature-request A request for a new feature low-priority This issue will not be solved by the Typeshare team, though others are free to work on it

Comments

@praveenperera
Copy link

praveenperera commented Apr 26, 2023

This is a great tool but I put some of the types that aren't separated into a helper file.

And then I manually import them into the file.

I also import files that are generated from another package.

// also generated by typeshare
import { AttachDirection, RawElement, RawElementId, RawTimelineId } from "./opset_types";
// helper file
import { JsonFraction } from "./rust_type_helpers";
// ==================================== GENERATED ====================================

... generated code here ...

It would be great if typeshare kept the code above
==================================== GENERATED ====================================

And only replaced the code below it.

@LuminaSapphira
Copy link
Collaborator

Hello, and thank you for your suggestion. This isn't a high priority because the combination of generated and manually created code can be handled within a script/toolchain. That said, we'd welcome community contribution on this matter.

@LuminaSapphira LuminaSapphira added feature-request A request for a new feature low-priority This issue will not be solved by the Typeshare team, though others are free to work on it labels May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A request for a new feature low-priority This issue will not be solved by the Typeshare team, though others are free to work on it
Projects
None yet
Development

No branches or pull requests

2 participants